Fonts UI#14
Closed
elisabettac77 wants to merge 4 commits intowolffe:masterfrom
Closed
Conversation
add Tom Select library scripts and styles
Improved the multi-select fields UI for Google and Bunny Fonts by using Tom Select library. Added proper wording to explain difference between the two and how to correctly setup Google fonts by obtaining a valid API key. Google Fonts selector is grayed out until API key is set and saved - when the API key is saved the field becomes active. Added button to clear all selected fonts to both selectors, the Google Font one is hidden until user sets a valid API key and saves it.
corrected error that triggered cpcs failed tests
Remove ellipsis from placeholder text in settings
Owner
|
Why remove the ellipsis? I always add it to all my placeholders. Regarding everything else, I agree. I might replace Tom Select with the tail.select library. It's way, way lighter. |
Contributor
Author
|
I removed a "u2026" in three places (that got added somehow in copy pasting from a "correct syntax" to AI because i am not any good for indentations and brackets and those things - so I always pass it into an AI to correct those mistakes because I know I make them (and somehow it added some unwanted stuff to the field placeholders this time because AIs sometimes hallucinate). Copilot interpreted it as "removed ellipsis". |
Owner
|
I cherry-picked some of the changes here and will release a new version tomorrow. Thank you @elisabettac77 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improved the UI for the two multi-select fields for Google and Bunny Fonts by adding Tom Select library.
(problem with previous implementation: hitting CTRL while accidentally scrolling up/down is interpreted as zomm in/out by browser, and accidentally hitting shift while scrolling attempts to select too many fonts at once and that hinders saving)
Made explanatory wording more clear for users and added a text to explain difference between Google and Bunny Fonts for clarity.