Skip to content

Codex/cert service ruff fix #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Jimuelle07 merged 6 commits into from
May 23, 2026
Merged

Codex/cert service ruff fix #79

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
7060ed3
Fix certificate service Ruff errors on main
Jimuelle07 May 23, 2026
db492d9
Fix backend Ruff violations across certificate and API modules
Jimuelle07 May 23, 2026
783c9ce
Fix router mounts and restore test fixture defaults
Jimuelle07 May 23, 2026
6b3a8b0
Refactor certificate rendering and add asset metadata
Jimuelle07 May 23, 2026
9c21e26
Refactor certificate HTML generation
Jimuelle07 May 23, 2026
cee655c
fixed merge conflict
Jimuelle07 May 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 18 additions & 18 deletions backend/app/api/v1/certificates.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
DonationCertificateUpdate,
)
from app.certificates.generator import generate_certificate_pdf
from app.certificates.svg_generator import generate_html_certificate

router = APIRouter(prefix="/certificates", tags=["certificates"])

Expand Down Expand Up @@ -90,24 +91,22 @@ async def get_public_certificate_page(
donor = (await db.execute(select(User).where(User.id == donation.donor_id))).scalar_one_or_none()
donor_name = cert.donor_name or (donor.stellar_public_key if donor else None) or "Anonymous Donor"
tx_hash = cert.stellar_tx_hash or donation.stellar_tx_hash or "N/A"
html = f"""
<!doctype html>
<html>
<head><meta charset="utf-8"><title>LINGAP Certificate {cert.id}</title></head>
<body style="font-family:Arial,sans-serif;background:#f5f7f5;padding:24px;color:#17231D;">
<div style="max-width:760px;margin:0 auto;background:#fff;border:1px solid #d7e1d9;border-radius:12px;padding:28px;">
<h1 style="margin:0 0 10px;">LINGAP On-Chain Donation Proof</h1>
<p style="margin:0 0 22px;color:#4A5C52;">Public Impact Certificate</p>
<p><strong>User Name:</strong> {donor_name}</p>
<p><strong>Campaign Name:</strong> {campaign_name}</p>
<p><strong>Milestone:</strong> {cert.milestone_description}</p>
<p><strong>Donation Amount:</strong> {float(cert.amount):,.2f} XLM</p>
<p><strong>Transaction Hash:</strong> {tx_hash}</p>
<p><strong>Verification:</strong> {"Verified" if cert.verified else "Pending"}</p>
</div>
</body>
</html>
"""
html = generate_html_certificate(
donor_name=donor_name,
amount=float(cert.amount),
beneficiary_name=campaign_name,
milestone_description=cert.milestone_description or "Campaign milestone completed",
lives_touched=int(cert.lives_touched or 0),
total_donated=float(cert.total_donated or cert.amount),
donation_date=donation.created_at,
stellar_tx_hash=tx_hash,
merkle_proof=cert.merkle_proof,
onchain_hash=cert.onchain_hash,
certificate_id=str(cert.id),
block_number=None,
network="Stellar Mainnet" if cert.verified else "Pending Verification",
certifying_officer="LINGAP Foundation",
)
return HTMLResponse(content=html)


Expand Down Expand Up @@ -264,6 +263,7 @@ async def list_certificates(
"donation_id": str(cert.donation_id),
"donor_name": cert.donor_name,
"amount": float(cert.amount),
"asset": donation.asset,
"beneficiary_name": cert.beneficiary_name,
"campaign_name": campaign_name,
"milestone_description": cert.milestone_description,
Expand Down
Loading
Loading