Security hardening, retry unification, model allowlists, image-text-to-text, and Kubernetes deployment

[eduardoworrel]

Summary

• Security hardening (S-series): mitigate SSRF, path traversal, unbounded file uploads, WebSocket abuse, missing rate-limiting on WS, and other vulnerabilities across the HTTP/WebSocket/queue pipeline
• Retry unification (A11): unify the two independent retry counters (PostProcessingQueue Redis-based + SessionTrackQueue in-memory) into a single PrivateArgs["retry_count"] stored in Redis, with a shared ceiling of 3 retries; register SessionTrackQueue in DI (was dead code), fix message deserialization, fix timer replacement for retried tasks, publish task_completion on success, and clean up Redis keys
• Error detection fix (E1): replace fragile response.Contains("\"Status\":\"Error\"") string matching with proper JsonDocument.Parse — prevents false HTTP 500 on valid responses that happen to contain the word "error" in their content
• Model/dtype allowlists (E2): add AllowedModels and AllowedDtypes to FieldsConfig, validated in IsValidFields() at the API boundary — rejects arbitrary model strings before they reach worker nodes
• New task type: image-text-to-text — adds multimodal vision AI endpoint (/api/v1/image-text-to-text) with full pipeline support (preprocessing, distribution, post-processing) for SmolVLM and similar models
• Kubernetes deployment: add k8s manifests for all services (core-api, core-websocket, core-background, client, redis) with namespace, PVC, cert-manager issuer, and ingress routing for subdomain architecture:
  • woolball.xyz → landing page
  • open.woolball.xyz → client app + API/WebSocket/Swagger
  • api.woolball.xyz → core-api (dedicated)
  • ws.woolball.xyz → core-websocket (dedicated)
• Refactoring: extract the 484-line TaskRequest god file into separate handler classes (SpeechToTextTaskHandler, TextToSpeechTaskHandler, TranslationTaskHandler, TextGenerationTaskHandler, ImageTextToTextTaskHandler), plus FieldsConfig, ITaskHandler, TaskHandlerFactory, StreamBuffer<T>, TaskRequestFactory, SpeechToTextFormProcessor

Bugs fixed

ID	Bug	Fix
S8-S14	Multiple security vulnerabilities (SSRF, path traversal, unbounded uploads, WS abuse)	Input sanitization, file size limits, origin validation
A11-0	SessionTrackQueue never registered in DI (dead code)	Added AddHostedService<SessionTrackQueue>()
A11-0a	DistributeQueue publishes GUID string, SessionTrackQueue tries Deserialize<TaskRequest>	Changed to Guid.TryParse
A11-1	task_completion never published — timers never cancelled on success	PostProcessingQueue now publishes task_completion + deletes Redis key
A11-2	_taskAttempts.GetOrAdd(taskId, 1) never increments — infinite retries	Removed in-memory counter, uses Redis retry_count
A11-3	TryAdd ignores re-dispatched tasks — no new timer	Changed to AddOrUpdate that cancels previous timer
A11-4	No coordination between two retry counters	Both systems now read/write same PrivateArgs["retry_count"] in Redis
A11-5	task:{id} never deleted after success	PostProcessingQueue deletes key after successful processing
E1	String matching error detection returns HTTP 500 for valid responses	Structural JSON parsing via JsonDocument
E2	No validation for model/dtype fields	Per-handler allowlists from README checked in IsValidFields()

Test plan

• dotnet build passes with 0 errors
• Verify grep -rn "_taskAttempts" src/ returns empty (in-memory counter fully removed)
• Verify grep -rn "task_completion" src/ returns 2+ results (publisher + subscriber)
• Verify grep -rn "AddHostedService<SessionTrackQueue>" src/ returns 1 result
• Send a translation request with valid content containing "error" — should return HTTP 200
• Send a request with an invalid model string — should return HTTP 400 with descriptive message
• End-to-end task flow: dispatch → worker → PostProcessingQueue publishes completion → SessionTrackQueue cancels timer → Redis key deleted
• kubectl apply -f k8s/ deploys all services successfully
• Image-text-to-text endpoint accepts image + text and returns generated description
• Ingress routes woolball.xyz, open.woolball.xyz, api.woolball.xyz, ws.woolball.xyz correctly

🤖 Generated with Claude Code