Skip to content

Null-check plugin-supplied pointers in v1 Scripts API #149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JustinMDotNet wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Null-check plugin-supplied pointers in v1 Scripts API #149

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions src/dll/v1/Funcs.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,12 @@ bool v1::GameStates::Add(RED4ext::v1::PluginHandle aHandle, RED4ext::EGameStateT

bool v1::Scripts::Add(RED4ext::v1::PluginHandle aHandle, const wchar_t* aPath)
{
if (!aPath)
{
spdlog::warn("Plugin with handle {} called Scripts::Add with a NULL path", fmt::ptr(aHandle));
return false;
}

auto app = App::Get();
if (!app)
{
Expand All @@ -140,6 +146,12 @@ bool v1::Scripts::Add(RED4ext::v1::PluginHandle aHandle, const wchar_t* aPath)

bool v1::Scripts::RegisterNeverRefType(const char* aType)
{
if (!aType)
{
spdlog::warn("Scripts::RegisterNeverRefType called with a NULL type name");
return false;
}

auto app = App::Get();
if (!app)
{
Expand All @@ -153,6 +165,12 @@ bool v1::Scripts::RegisterNeverRefType(const char* aType)

bool v1::Scripts::RegisterMixedRefType(const char* aType)
{
if (!aType)
{
spdlog::warn("Scripts::RegisterMixedRefType called with a NULL type name");
return false;
}

auto app = App::Get();
if (!app)
{
Expand Down