chore(deps): update dotnet-sdk to v10 (major)#166
Open
Workleap IT (Infra-Workleap) wants to merge 1 commit into
Open
chore(deps): update dotnet-sdk to v10 (major)#166Workleap IT (Infra-Workleap) wants to merge 1 commit into
Workleap IT (Infra-Workleap) wants to merge 1 commit into
Conversation
5638d23 to
8c95492
Compare
22ec2ec to
19eb5de
Compare
e0f8845 to
bb15c85
Compare
3b584f0 to
6e6736f
Compare
cd95f76 to
e155f5f
Compare
e155f5f to
623ea80
Compare
623ea80 to
7688b83
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the container build/runtime for the EventGridEmulator by bumping the .NET Docker base images to .NET 10, aligning the Dockerfile with the intended dependency update.
Changes:
- Bump
mcr.microsoft.com/dotnet/aspnetimage from9.0-alpineto10.0-alpine - Bump
mcr.microsoft.com/dotnet/sdkimage from9.0-alpineto10.0-alpine
Comments suppressed due to low confidence (1)
src/EventGridEmulator/Dockerfile:12
- The app is still targeting .NET 9 (see src/Directory.Build.props:3 => net9.0). With these images bumped to 10.0-alpine and the publish step still framework-dependent ("--no-self-contained"), the resulting container will likely fail at startup because the ASP.NET Core 9.0 shared framework isn’t present in the 10.0 runtime image. Either keep the base/publish images on 9.0 until the repo targets net10.0, or update the TargetFramework to net10.0 (and validate all deps), or switch to a self-contained publish/runtime-deps base if you explicitly want to decouple from the shared framework version.
FROM mcr.microsoft.com/dotnet/sdk:10.0-alpine AS publish
WORKDIR /src
COPY . .
WORKDIR "/src/EventGridEmulator"
RUN dotnet publish "EventGridEmulator.csproj" -c Release -r linux-musl-x64 --no-self-contained --nologo -p:RunAnalyzers=false -o /app/publish
3580034 to
4ac3c1f
Compare
4ac3c1f to
a7ed4d9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
9.0-alpine→10.0-alpine9.0-alpine→10.0-alpineConfiguration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about these updates again.
This PR has been generated by Renovate Bot.