chore(deps): update nuget dependencies (major)#146
Open
Workleap IT (Infra-Workleap) wants to merge 1 commit into
Open
chore(deps): update nuget dependencies (major)#146Workleap IT (Infra-Workleap) wants to merge 1 commit into
Workleap IT (Infra-Workleap) wants to merge 1 commit into
Conversation
ffb4d54 to
e64efd8
Compare
e64efd8 to
bbe9e18
Compare
bbe9e18 to
4df513b
Compare
4df513b to
9a60b3e
Compare
9a60b3e to
07368ca
Compare
07368ca to
5d1c88c
Compare
c4aefc1 to
426a4d6
Compare
426a4d6 to
84c3be7
Compare
84c3be7 to
c81870c
Compare
c81870c to
4dd12ee
Compare
4dd12ee to
e7cc1f2
Compare
e7cc1f2 to
850113d
Compare
850113d to
558c4b0
Compare
558c4b0 to
524164a
Compare
524164a to
30ff4f3
Compare
There was a problem hiding this comment.
Pull request overview
Updates NuGet package references across the MSBuild task and its test project, primarily moving dependencies to newer major versions (including MSBuild-related and analyzer packages).
Changes:
- Bumped
YamlDotNetto17.1.0in both the task package and tests. - Upgraded test dependencies, including
Microsoft.Build.Framework/Microsoft.NET.Test.SdkandMeziantou.Framework.*to2.0.0. - Updated
Workleap.DotNet.CodingStandardsto2.0.0inDirectory.Build.props.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| src/Workleap.OpenApi.MSBuild/Workleap.OpenApi.MSBuild.csproj | Updates YamlDotNet; task project still pins MSBuild Utilities at 17.x. |
| src/tests/Workleap.OpenApi.MSBuild.Tests/Workleap.OpenApi.MSBuild.Tests.csproj | Upgrades test dependencies, including MSBuild/Test SDK and Meziantou packages. |
| src/Directory.Build.props | Upgrades Workleap.DotNet.CodingStandards analyzer package to v2. |
Comments suppressed due to low confidence (1)
src/tests/Workleap.OpenApi.MSBuild.Tests/Workleap.OpenApi.MSBuild.Tests.csproj:18
- PR description lists Microsoft.Build.Framework 18.4.0 and Microsoft.NET.Test.Sdk 18.3.0, but the project file is updated to 18.6.3 and 18.5.1. Please update the PR description (or pin the versions) so the stated dependency changes match what will actually be merged.
<PackageReference Include="Microsoft.Build.Framework" Version="18.6.3" />
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="18.5.1" />
Comment on lines
+25
to
+27
| <PackageReference Include="CliWrap" Version="3.9.0" PrivateAssets="all" /> | ||
| <PackageReference Include="Microsoft.Build.Utilities.Core" Version="17.10.46" PrivateAssets="all" /> | ||
| <PackageReference Include="YamlDotNet" Version="16.3.0" PrivateAssets="all" /> | ||
| <PackageReference Include="YamlDotNet" Version="17.1.0" PrivateAssets="all" /> |
| <PackageReference Include="Microsoft.Build.Framework" Version="17.10.46" /> | ||
| <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.14.1" /> | ||
| <PackageReference Include="YamlDotNet" Version="16.3.0" /> | ||
| <PackageReference Include="Microsoft.Build.Framework" Version="18.6.3" /> |
Comment on lines
14
to
17
| <PackageReference Include="Workleap.DotNet.CodingStandards" Version="2.0.0"> | ||
| <PrivateAssets>all</PrivateAssets> | ||
| <IncludeAssets>runtime; build; native; contentfiles; analyzers</IncludeAssets> | ||
| </PackageReference> |
Comment on lines
+14
to
+19
| <PackageReference Include="Meziantou.Framework.FullPath" Version="2.0.0" /> | ||
| <PackageReference Include="Meziantou.Framework.TemporaryDirectory" Version="2.0.0" /> | ||
| <PackageReference Include="Meziantou.Xunit.ParallelTestFramework" Version="2.3.0" /> | ||
| <PackageReference Include="Microsoft.Build.Framework" Version="17.10.46" /> | ||
| <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.14.1" /> | ||
| <PackageReference Include="YamlDotNet" Version="16.3.0" /> | ||
| <PackageReference Include="Microsoft.Build.Framework" Version="18.6.3" /> | ||
| <PackageReference Include="Microsoft.NET.Test.Sdk" Version="18.5.1" /> | ||
| <PackageReference Include="YamlDotNet" Version="17.1.0" /> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
1.1.3→2.0.11.0.20→2.0.217.10.46→18.6.317.14.1→18.6.01.1.31→2.0.216.3.0→18.0.0Release Notes
dotnet/msbuild (Microsoft.Build.Framework)
v18.6.3What's Changed
Includeattributes by @glektarssza in #132841357533by @dotnet-bot in #13394New Contributors
Full Changelog: dotnet/msbuild@v18.5.4...v18.6.3
v18.4.0What's Changed
1305085by @dotnet-bot in #129821305236by @dotnet-bot in #129841307838by @dotnet-bot in #130031307982by @dotnet-bot in #130101312418by @dotnet-bot in #130531313748by @dotnet-bot in #130751313792by @dotnet-bot in #130811316676by @dotnet-bot in #131071316744by @dotnet-bot in #131171318654by @dotnet-bot in #13128Full Changelog: dotnet/msbuild@v18.3.3...v18.4.0
v18.3.3What's Changed
1253149by @dotnet-bot in #126131255171by @dotnet-bot in #126281255852by @dotnet-bot in #126291256734by @dotnet-bot in #126331276498by @dotnet-bot in #127541281631by @dotnet-bot in #12763Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.
This PR has been generated by Renovate Bot.