Repository navigation
polish(extension): marketplace metadata + onboarding UX consistency - #9
Merged
Merged
Conversation
…T.md Adds categories, keywords, gallery banner, badges, homepage, pricing, and author to the manifest; bundles CHANGELOG.md into the VSIX for the Marketplace's Changelog tab; adds SUPPORT.md as a GitHub community health file (deliberately excluded from the packaged VSIX via .vscodeignore — it drives GitHub's issue-creation flow, not a Marketplace tab). Untracked/uncommitted work found sitting in the working tree from a prior session, predating today's 0.1.3 publish. Verified: valid JSON, clean typecheck/build, 82/82 tests, and vsce accepts every new manifest field (validated with a real `npm run package` build). Corrected the changelog's stale "0.1.2" heading to "Unreleased" since none of this shipped in any published version yet — it lands in whatever version is tagged next.
- Revert categories to ["Other"]: Linters/SCM Providers/Testing were false — the extension implements none of those VS Code APIs (no DiagnosticCollection, no SCM provider, no TestController). This is exactly the overclaiming this codebase's own copy elsewhere refuses to do (tooltips.ts, semanticModel.ts). - Fix CHANGELOG.md: walkthrough has four steps, not three. - Fix CHANGELOG.md: SUPPORT.md isn't at a location GitHub recognizes as a community health file, so it doesn't "drive" anything yet — reworded to stop claiming a wiring that doesn't exist. Missing 0.1.1/0.1.2/0.1.3 changelog entries left as a known gap (flagged, not fabricated) rather than reconstructed from an unlabeled commit history with no clean per-version boundary.
Requested a /sc:analyze pass on the extension's architecture and command-palette/onboarding integration, grounded against the official VS Code Command Palette UX guidelines (docs confirm: use clear names, group commands under one category — the latter already holds here). Two findings, both fixed: 1. 6 of 7 visible commands use verb-first imperative titles (Show, Inspect, Run, Open); "Getting Started" was the one gerund noun phrase. Renamed to "Open Getting Started Walkthrough" for pattern consistency. (Ruled out a VS Code built-in title collision as the root cause of the reported onboarding bug: VS Code's own entries are "Help: Open Walkthrough..." and "Help: Welcome", not "Getting Started" — no direct string clash. Traced WALKTHROUGH_ID history: a real publisher-id typo existed once, historically, but was fixed in d753ede, long before today, and is confirmed correct on main.) 2. The Command-Palette-only "Open Intelligence File" command's no-file warning was a dead end — every other surface (welcome states, walkthrough) points to Getting Started when workspace.json is missing; this one didn't. Added the same actionable button. No logic, decision, or evidence-model changes. 82/82 tests still pass.
…version drift gate Adds the extension's "Generate Intelligence" command/walkthrough step so a user with no .agents/workspace.json can invoke the reference generator (agents-audit) without the extension authoring the artifact itself (sendText only, never fs.write). Names the producer on every consumer surface (README, extension, walkthrough) that previously never mentioned it, per the HAC-197 cold-run finding. Installer: removes the unrequested .gitignore auto-write (HAC-203) in favor of printing the ignore instruction; the install receipt now checks for .agents/workspace.json and prints generate instructions instead of reporting PASS when no artifact exists. Adds scripts/check-generator-version.mjs (+ CI wiring) to catch drift across the now six-plus copies of the pinned agents-audit version instead of hand-syncing them. README: corrects the "Verify in two minutes" section, which previously told readers to generate a file then rely on fragility flags that `generate` never produces — now points that demo at fixture/, which carries hand-authored manual evidence. Does NOT touch the reviewer-key documentation gap (missing WORKSPACEJSON_REVIEWER_MODEL, the "no network calls" claim sitting in the same sentence as the advisory review) — that stays open under HAC-205. Reviewed adversarially across three rounds this session; all BLOCK findings resolved, remaining observations (registry-coupling in the version-check gate, walkthrough onContext over-completion on non-happy states) accepted as known, non-blocking trade-offs.
…-204) The pin is the contract; the registry is the world. Failing CI when an upstream agents-audit release moves ahead of a deliberate pin makes every upstream publish an incident in this downstream repo. Remove the registry fetch and the pinned!=latest failure; keep the cross-surface agreement check (every surface pins the same version as every other). Reconciling the pin against the *installed* agents-audit version is the redesign left to HAC-204. A regression test locks in the intentional non-behavior: a pin behind the registry latest is not a violation.
Stages the 0.1.6 version across the three sync points (package.json, package-lock, runtime VERSION in src/index.ts) so the release cut is a single merge. Extension stays 0.1.2 (separate track; republish decision tracked in HAC-200). Proven demo path is against agents-audit@0.4.3.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CHANGELOG.md,SUPPORT.md— recovered from uncommitted WIP found sitting in the working tree from a prior session, plus fixes for factual errors found in adversarial review (categories overclaimed APIs the extension doesn't implement; walkthrough step count was wrong; SUPPORT.md's GitHub-integration claim was inaccurate for its file location)./sc:analyzepass grounded against the VS Code Command Palette UX guidelines:Test plan
tsc -p tsconfig.jsoncleannode --test out/test/*.check.js— 82/82 passing throughoutnpm run package(realvsce package) succeeds; manifest fields validated against@vscode/vsce3.9.2's own validation