Skip to content

Turkish railways#178

Merged
Gabe-Levin merged 8 commits into
mainfrom
turkish_railways
Apr 13, 2026
Merged

Turkish railways#178
Gabe-Levin merged 8 commits into
mainfrom
turkish_railways

Conversation

@bpstewar
Copy link
Copy Markdown
Collaborator

Several general updates; nothing substantial

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds several exploratory/implementation notebooks (STAC GeoParquet generation, roads density/connectivity exploration, LSMS urban classification, and M300 imagery estimates), updates a few user-documentation notebooks for the Space2Stats client/API, and adds a World Bank IGO rider document.

Changes:

  • Add new notebooks for STAC-GeoParquet generation and analysis/estimation workflows (roads, LSMS urban, M300).
  • Update user-doc notebooks for Space2Stats API demos (including AOI + flood-risk and SPI drought examples).
  • Add WB-IGO-RIDER.md procedural terms.

Reviewed changes

Copilot reviewed 9 out of 10 changed files in this pull request and generated 14 comments.

Show a summary per file
File Description
notebooks/STAC_Testing/GENERATE_STAC_GEOPARQUET.ipynb New experiment notebook to convert parquet→geoparquet and build a STAC catalog/items.
notebooks/MP_SCRIPTS/roads/exploring_density_connectivity.ipynb New exploratory notebook for road density/connectivity calculations using Overture.
notebooks/MP_SCRIPTS/Landcover/TEST_zonal_stats_LC_built.ipynb Minor notebook edits plus additional exploratory cells appended to an already very large notebook.
notebooks/IMPLEMENTATIONS/LSMS_urban_calculation/LSMS_urban_calc.ipynb New workflow notebook to compute DEGURBA-like urbanization attributes for LSMS households.
notebooks/IMPLEMENTATIONS/ESMAP_imagery_estimates/S2S_connect_m300.ipynb New notebook to summarize GHS-based metrics for M300 countries.
docs/user-docs/space2stats_exploring_admin_summaries.ipynb User documentation notebook (listed as changed in PR contents).
docs/user-docs/space2stats_api_demo_urban_flood_risk.ipynb Update user demo for AOI-driven urban flood risk queries and mapping output.
docs/user-docs/space2stats_api_demo_spi_droughts.ipynb Update SPI drought demo notebook (now includes pip install and a captured runtime error).
docs/user-docs/space2stats_api_demo.ipynb Update general API demo notebook (currently captured with an import failure).
WB-IGO-RIDER.md Add procedural license terms for IGO licensors.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread notebooks/STAC_Testing/GENERATE_STAC_GEOPARQUET.ipynb
Comment thread notebooks/IMPLEMENTATIONS/LSMS_urban_calculation/LSMS_urban_calc.ipynb Outdated
Comment thread docs/user-docs/space2stats_api_demo_urban_flood_risk.ipynb Outdated
Comment thread notebooks/STAC_Testing/GENERATE_STAC_GEOPARQUET.ipynb Outdated
Comment on lines +2239397 to +2239402
{
"cell_type": "markdown",
"metadata": {},
"source": [
"# Exploring parquet data"
]
Copy link

Copilot AI Mar 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This notebook is already extremely large (millions of lines in the JSON) and the PR adds additional cells, which makes diffs/reviews and cloning noticeably harder. Consider clearing outputs and stripping execution metadata before committing, or moving exploratory work into a smaller notebook/script to keep the repo manageable.

Copilot uses AI. Check for mistakes.
" print(\"Download complete.\")\n",
"\n",
" with zipfile.ZipFile(out_pop_zip_file.format(year=year), 'r') as zip_ref:\n",
" zip_ref.extractall(out_folder)\n",
Copy link

Copilot AI Mar 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When unzipping the GHS_POP archives, the code extracts into out_folder (SMOD) instead of out_pop_folder (SMOD_POP). This will mix datasets and likely make ghs_pop_path point at a file that was never extracted. Extract the POP zip into out_pop_folder.

Suggested change
" zip_ref.extractall(out_folder)\n",
" zip_ref.extractall(out_pop_folder)\n",

Copilot uses AI. Check for mistakes.
Comment thread docs/user-docs/space2stats_api_demo.ipynb
@worldbank worldbank deleted a comment from Copilot AI Mar 27, 2026
@worldbank worldbank deleted a comment from Copilot AI Mar 27, 2026
@worldbank worldbank deleted a comment from Copilot AI Mar 27, 2026
@worldbank worldbank deleted a comment from Copilot AI Mar 27, 2026
@worldbank worldbank deleted a comment from Copilot AI Mar 27, 2026
@worldbank worldbank deleted a comment from Copilot AI Mar 27, 2026
@worldbank worldbank deleted a comment from Copilot AI Mar 27, 2026
bpstewar and others added 6 commits April 13, 2026 09:38
…lc.ipynb

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
… in GENERATE_STAC_GEOPARQUET.ipynb

Agent-Logs-Url: https://github.com/worldbank/DECAT_Space2Stats/sessions/ae8415a0-f897-4140-b704-9548d5face70

Co-authored-by: bpstewar <5446296+bpstewar@users.noreply.github.com>
@Gabe-Levin Gabe-Levin temporarily deployed to Space2Stats API Dev April 13, 2026 08:16 — with GitHub Actions Inactive
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 13, 2026

PR Deployment Details:
🚀 PR deployed to https://5xhrsa0u0m.execute-api.us-east-1.amazonaws.com/

@Gabe-Levin Gabe-Levin assigned Gabe-Levin and unassigned Gabe-Levin Apr 13, 2026
@Gabe-Levin Gabe-Levin self-requested a review April 13, 2026 08:35
@Gabe-Levin Gabe-Levin merged commit 897a6c5 into main Apr 13, 2026
6 checks passed
@Gabe-Levin Gabe-Levin had a problem deploying to Space2Stats API Dev April 13, 2026 08:50 — with GitHub Actions Failure
@Gabe-Levin Gabe-Levin deleted the turkish_railways branch April 13, 2026 08:50
@Gabe-Levin Gabe-Levin temporarily deployed to Space2Stats API Dev April 13, 2026 08:53 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants