Turkish railways#178
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds several exploratory/implementation notebooks (STAC GeoParquet generation, roads density/connectivity exploration, LSMS urban classification, and M300 imagery estimates), updates a few user-documentation notebooks for the Space2Stats client/API, and adds a World Bank IGO rider document.
Changes:
- Add new notebooks for STAC-GeoParquet generation and analysis/estimation workflows (roads, LSMS urban, M300).
- Update user-doc notebooks for Space2Stats API demos (including AOI + flood-risk and SPI drought examples).
- Add
WB-IGO-RIDER.mdprocedural terms.
Reviewed changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated 14 comments.
Show a summary per file
| File | Description |
|---|---|
| notebooks/STAC_Testing/GENERATE_STAC_GEOPARQUET.ipynb | New experiment notebook to convert parquet→geoparquet and build a STAC catalog/items. |
| notebooks/MP_SCRIPTS/roads/exploring_density_connectivity.ipynb | New exploratory notebook for road density/connectivity calculations using Overture. |
| notebooks/MP_SCRIPTS/Landcover/TEST_zonal_stats_LC_built.ipynb | Minor notebook edits plus additional exploratory cells appended to an already very large notebook. |
| notebooks/IMPLEMENTATIONS/LSMS_urban_calculation/LSMS_urban_calc.ipynb | New workflow notebook to compute DEGURBA-like urbanization attributes for LSMS households. |
| notebooks/IMPLEMENTATIONS/ESMAP_imagery_estimates/S2S_connect_m300.ipynb | New notebook to summarize GHS-based metrics for M300 countries. |
| docs/user-docs/space2stats_exploring_admin_summaries.ipynb | User documentation notebook (listed as changed in PR contents). |
| docs/user-docs/space2stats_api_demo_urban_flood_risk.ipynb | Update user demo for AOI-driven urban flood risk queries and mapping output. |
| docs/user-docs/space2stats_api_demo_spi_droughts.ipynb | Update SPI drought demo notebook (now includes pip install and a captured runtime error). |
| docs/user-docs/space2stats_api_demo.ipynb | Update general API demo notebook (currently captured with an import failure). |
| WB-IGO-RIDER.md | Add procedural license terms for IGO licensors. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| { | ||
| "cell_type": "markdown", | ||
| "metadata": {}, | ||
| "source": [ | ||
| "# Exploring parquet data" | ||
| ] |
There was a problem hiding this comment.
This notebook is already extremely large (millions of lines in the JSON) and the PR adds additional cells, which makes diffs/reviews and cloning noticeably harder. Consider clearing outputs and stripping execution metadata before committing, or moving exploratory work into a smaller notebook/script to keep the repo manageable.
| " print(\"Download complete.\")\n", | ||
| "\n", | ||
| " with zipfile.ZipFile(out_pop_zip_file.format(year=year), 'r') as zip_ref:\n", | ||
| " zip_ref.extractall(out_folder)\n", |
There was a problem hiding this comment.
When unzipping the GHS_POP archives, the code extracts into out_folder (SMOD) instead of out_pop_folder (SMOD_POP). This will mix datasets and likely make ghs_pop_path point at a file that was never extracted. Extract the POP zip into out_pop_folder.
| " zip_ref.extractall(out_folder)\n", | |
| " zip_ref.extractall(out_pop_folder)\n", |
…lc.ipynb Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
… in GENERATE_STAC_GEOPARQUET.ipynb Agent-Logs-Url: https://github.com/worldbank/DECAT_Space2Stats/sessions/ae8415a0-f897-4140-b704-9548d5face70 Co-authored-by: bpstewar <5446296+bpstewar@users.noreply.github.com>
1c00cbc to
b09cdfb
Compare
|
PR Deployment Details: |
Several general updates; nothing substantial