Conversation
|
PR Deployment Details: |
bpstewar
reviewed
Apr 20, 2026
Collaborator
There was a problem hiding this comment.
In the get_adm2_summaries defintion, the dataset parameter has hard-coded options, which should pull from the ddh_datasets.json keys
bpstewar
approved these changes
Apr 20, 2026
Collaborator
bpstewar
left a comment
There was a problem hiding this comment.
Everything looks good, although we may need to make some updates after testing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I changed
Extracted hardcoded ADM2 dataset config from
client.pyinto a standaloneddh_datasets.json— single source of truth that supports multiple resource links per topic for upcoming multi-year datasets.ddh_datasets.jsonwithdescription,metadatalink, anddatasetsdict (year → resource ID)get_adm2_dataset_info()withget_adm2_datasets()— richer DataFrame outputyearparameter toget_adm2_summaries()(defaults to latest)pyproject.toml, README, and testsHow to test