Open
Conversation
Add a generic ERC20 approve constructor in the contract transaction layer and expose a matching SafeSmartAccount transaction_erc20_approve API. This lets native clients submit a standard token approve(spender, amount) call through the existing 4337 transaction pipeline. World Card onboarding needs this to grant Permit2 spending approval before submitting the separate Permit2 allowance for the funding contract.
forceunwrap
requested review from
Dzejkop,
andy-t-wang,
aurel-fr,
karankurbur,
murph,
paolodamico,
sideround and
tomislavhoman
as code owners
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6d9fa3d547
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Approvals routed through Erc20::approve() were tagged as TransactionTypeId::Transfer in the 4337 nonce key. Introduce a standalone Erc20Approve struct with its own Is4337Encodable impl using TransactionTypeId::Erc20Approve (141) so downstream logic that relies on nonce type IDs can distinguish approvals from transfers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a generic ERC20 approve constructor in the contract transaction layer and expose a matching SafeSmartAccount transaction_erc20_approve API.
This lets native clients submit a standard token approve(spender, amount) call through the existing 4337 transaction pipeline. World Card onboarding needs this to grant Permit2 spending approval before submitting the separate Permit2 allowance for the funding contract.