Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Takaros999
requested review from
0x1,
Gr1dlock,
Guardiola31337,
SeanROlszewski,
andy-t-wang,
murph and
paolodamico
as code owners
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 76ccc45de0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
|
Unable to authenticate your request. Please make sure to connect your GitHub account to Cursor. Go to Cursor |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ca3f077a11
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| let signal_hash = self | ||
| .signal_hashes | ||
| .get(item.verification_level.as_ref()) | ||
| .cloned(); | ||
| .cached_signal_hashes | ||
| .get(item.verification_level.as_ref()); |
There was a problem hiding this comment.
CachedSignalHashes::compute now stores legacy hashes separately instead of under legacy_verification_level, but this branch still resolves hashes only via item.verification_level; for legacy_responses, those identifiers are legacy levels (orb, document, etc.) and usually do not match the cached V4 keys (proof_of_human, passport, ...), so signal_hash is dropped in confirmed 3.0 results. This regresses bridge flows that return legacy_responses (notably legacy multi-credential paths) because callers that rely on injected signal_hash will now receive None even when a signal was provided.
Useful? React with 👍 / 👎.
2 participants
This PR addresses an edge case in how we cache a signal. In the legacy flow, requesting
VerificationLevel.Devicecould return an orb ZKP and we didn't inject the correctsignal_hashto the response.CachedSignalHashesstruct and document the correct behaviourBefore
IDKit.Next.js.Example.-.11.March.2026.mp4
After
IDKit.Next.js.Example.-.11.March.2026.1.mp4