Skip to content

Modernize deprecated syntax in Behat tests - #536

Merged
schlessera merged 1 commit into
mainfrom
fix/modernize-deprecated-behat-syntax
Jul 23, 2026
Merged

schlessera merged 1 commit into
mainfrom
fix/modernize-deprecated-behat-syntax

Conversation

@schlessera

Copy link
Copy Markdown
Member

What

Updates the Behat tests to use the current command syntax instead of forms deprecated by wp-cli/wp-cli#6356.

Why

The framework now emits a deprecation warning to STDERR when it rewrites these legacy forms. This breaks When I run steps, which expect STDERR to remain empty.

Tests

  • Static and unit test stages from composer test
  • Changed Behat scenarios
  • composer behat passed 272 of 277 scenarios; the remaining failures involve stale temporary download artifacts or live GitHub API/auth responses

WP-CLI now emits deprecation warnings when it rewrites legacy command syntax. Use the modern forms in the Behat scenarios so the standard run step can continue to require clean STDERR.
@schlessera schlessera added this to the 2.3.7 milestone Jul 23, 2026
@schlessera schlessera added command:plugin Related to 'plugin' command command:theme Related to 'theme' command scope:testing Related to testing command:plugin-uninstall Related to 'plugin uninstall' command labels Jul 23, 2026
@coderabbitai

coderabbitai Bot commented Jul 23, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 26b6ddff-044e-4f80-8102-e22a63d2a0e7

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • ✅ Review completed - (🔄 Check again to review again)
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/modernize-deprecated-behat-syntax

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added command:plugin-update Related to 'plugin update' command command:plugin-install Related to 'plugin install' command command:theme-install Related to 'theme install' command command:theme-update Related to 'theme update' command labels Jul 23, 2026
@schlessera schlessera removed command:plugin-update Related to 'plugin update' command command:theme-update Related to 'theme update' command command:plugin-install Related to 'plugin install' command command:theme-install Related to 'theme install' command labels Jul 23, 2026
@schlessera
schlessera marked this pull request as ready for review July 23, 2026 06:08
@schlessera
schlessera requested a review from a team as a code owner July 23, 2026 06:08
@codecov

codecov Bot commented Jul 23, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@schlessera
schlessera merged commit 3d5a0d7 into main Jul 23, 2026
67 checks passed
@schlessera
schlessera deleted the fix/modernize-deprecated-behat-syntax branch July 23, 2026 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

command:plugin Related to 'plugin' command command:plugin-uninstall Related to 'plugin uninstall' command command:theme Related to 'theme' command scope:testing Related to testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants