Skip to content

Telemetry Framework - #5094

Closed
Starlight220 wants to merge 6 commits into
wpilibsuite:mainfrom
Starlight220:telemetry
Closed

Starlight220 wants to merge 6 commits into
wpilibsuite:mainfrom
Starlight220:telemetry

Conversation

@Starlight220

Copy link
Copy Markdown
Member

Initial work for the telemetry API suggested in @Oblarg 's design doc.

@Oblarg

Oblarg commented Feb 13, 2023

Copy link
Copy Markdown
Contributor

Great to see work started on this!

Remember that in the most-recent version of the doc, dashboard widget config would occur in its own topic via json message content, rather than in the topic metadata.

@Starlight220

Starlight220 commented Feb 13, 2023

Copy link
Copy Markdown
Member Author

We've discussed multiple changes that didn't make it into the doc, and we should probably discuss further. Is this the place?

UPDATE: per Oblarg/docs#5 (comment), widget preference is included in object metadata.

@Starlight220

Starlight220 commented Mar 3, 2023

Copy link
Copy Markdown
Member Author

After some second thinking, I'm not sure whether completely breaking everything (Sendable is depended on by nearly everything) is the best idea.

I think that a lot of the current problems with Sendable are more with the way it's used by the LiveWindow, SmartDashboard, and Shuffleboard APIs than with Sendable itself (which is a rather simple API), so fixing it incrementally with minimal breakage should be possible.

@Starlight220

Copy link
Copy Markdown
Member Author

Discussion at #5177.

@calcmogul calcmogul added the component: telemetry High level telemetry functionality label Dec 2, 2023
@PeterJohnson

Copy link
Copy Markdown
Member

Superseded by #6453.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component: telemetry High level telemetry functionality

Projects

Status: Done
Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants