Models, Associations & Database schema based on ERD including tests by wra-wtag · Pull Request #5 · wra-wtag/Job-Portal

wra-wtag · 2025-09-23T06:12:48Z

Models, Associations & Database Schema Setup

Trello Ticket: Models, Associations & Database Schema Setup

Description

Created all core database models and their associations based on the ERD. Added validations and unit tests for all models to ensure correctness.

Changes

Models created: User, Company, Job, Application, RecruiterMembership, Bookmark, Notification, Skill, JobRecommendation
Added associations between models
Added validations for required fields
Wrote unit tests for all models
Verified models work correctly in Rails console

…th-tests

…issue

…-on-erd-with-tests

… values

…-on-erd-with-tests

hoh-wtag · 2025-10-15T03:07:25Z

@@ -0,0 +1,32 @@
+class Application < ApplicationRecord
+  belongs_to :job, counter_cache: :applications_count


why are we using counter_cache here? Can you please explain?

Hello @hoh-wtag bhai, The counter_cache is a Rails performance optimization feature. Without counter_cache: if we wanted to list out all the applications or total applications count, we had to perform another query on the database. By using counter_cache, we are actually reducing that extra query, this is related to the N+1 Query problem i studied in Rails Docs.

Thanks bhai.

hoh-wtag · 2025-10-15T03:10:29Z

 #
 # It's strongly recommended that you check this file into your version control system.

-ActiveRecord::Schema[8.0].define(version: 2025_09_24_090332) do


You have all your migrations in this PR, but how does the changes in schema file exist in the base branch?

@hoh-wtag bhai, sorry for that. It happened because i pulled the initiate-rails branch here and then mistakenly accepted incoming changes of the schema file in the current branch. that's why it happened.

hoh-wtag · 2025-10-15T03:11:56Z


  # Don't care if the mailer can't send.
-  config.action_mailer.raise_delivery_errors = false
+  config.action_mailer.raise_delivery_errors = true


Can you please explain what's the purpose of changing thos to true?

Hello @hoh-wtag bhai, I actually set it to true because i wanted the application to raise an error whenever it is failed to send an email. If set to false, the application will silently run without raising any error, however just sending the error in the log.

hoh-wtag · 2025-10-15T03:13:07Z

+  belongs_to :job, counter_cache: :applications_count
+  belongs_to :user
+
+  enum :status, { applied: 0, viewed: 1, shortlisted: 2, rejected: 3, hired: 4, withdrawn: 5 }


validates :status, inclusion: { in: statuses.keys }

Do we need additional validation for enum?

@hoh-wtag bhai, added the validation. Thank you.

hoh-wtag · 2025-10-15T03:16:09Z

+
+  validates :job_id, uniqueness: { scope: :user_id, message: "You have already applied for this job" }
+
+  has_one_attached :resume


can we add validations on the file types of the reswume, so that users cannot upload any kinds of files?

@hoh-wtag added the validation for resume, Thank you.

hoh-wtag · 2025-10-15T03:51:48Z

+  end
+
+  def recommended_jobs
+    return [] unless payload["job_ids"].present?


use jsonb in the DB and cast it in the model using Rails’ typed attributes

store_accessor :payload, :job_ids

@hoh-wtag bhai, fixed it. Thank you

hoh-wtag · 2025-10-15T03:53:26Z

+  scope :managers, -> { where(role: :manager) }
+  scope :standard, -> { where(role: :standard) }
+  scope :primary, -> { where(is_primary: true) }
+  scope :pending, -> { where(status: :pending) }
+  scope :approved, -> { where(status: :approved) }
+  scope :rejected, -> { where(status: :rejected) }


@hoh-wtag bhai, fixed. Thank you

hoh-wtag · 2025-10-15T03:54:53Z

+    has_many :user_skills, dependent: :destroy
+    has_many :users, through: :user_skills


If we use has_many :users, through: :user_skills do we need has_many :user_skills, dependent: :destroy seperately?

@hoh-wtag bhai, without dependent: :destroy on user_skills, rails won't auto-delete UserSkill rows. We might end up with a foreign key error blocking deletion if we use DB FKs.

hoh-wtag · 2025-10-15T03:55:30Z

@@ -0,0 +1,9 @@
+class UserSkill < ApplicationRecord
+  validates :user_id, uniqueness: { scope: :skill_id }
+  validates :experience_years, numericality: { greater_than_or_equal_to: 0 }


Suggested change

validates :experience_years, numericality: { greater_than_or_equal_to: 0 }

validates :years_of_experience, numericality: { greater_than_or_equal_to: 0 }

@hoh-wtag bhai, fixed. Thank you.

hoh-wtag · 2025-10-15T03:55:59Z


+gem "devise"
 gem "email_validator"
+gem "grape"


why do we need grape in this PR?

@hoh-wtag bhai, deleted grape gem. Thank you

…mmendation model payload

wra-wtag added 13 commits September 23, 2025 12:12

User model creation

48970da

Company Model creation

53e3c00

Job Model creation

c36a6c9

Application Model Creation

f95e1a2

Recruiter Membership model creation

d5eb68b

Bookmark model creation

8c18147

Notification Model Creation

55bdfdc

Skill Models Creation

57ac623

Job Recommendation Model Creation

0151d78

Written User Model test

2ba6004

Write test for Company and Job model

0af5625

Write Skill Application and Notification model test

584c45d

Write Test for Other models

62b1994

wra-wtag changed the title ~~User model creation~~ Model Creation and Testing Sep 24, 2025

wra-wtag added 5 commits September 24, 2025 13:50

Removed Unnecessary Comments from Model files

1f82eea

Added Status column into the recruiter membership model

e92f2ac

added methods for different status into the user model

3193757

Merge branch 'Gems' into core-models-and-associations-based-on-erd-wi…

bfc8c38

…th-tests

Removed Single Quote and Added double quote and fixed no end of line …

d446c88

…issue

wra-wtag changed the title ~~Model Creation and Testing~~ Models, Associations & Database schema based on ERD including tests Sep 30, 2025

wra-wtag added 10 commits September 30, 2025 15:34

Adding status in the recruiter membership table

d100c68

Added Enum for user role and write tests

f4bf3d8

Added Test files for application and changed status to enum

17119aa

Changed Company Status to enum

87f2729

Changed employment type and job status in job model to enum

9f9677d

Added enum for notification kind in notification model

3c6806a

Added enum for role and status for recruiter membership model

620531d

Updated Spec files in order to match with enum functionality

590209c

Fixed Extra spaces and single quote and end of line issues

72c47f9

Made default company status pending

ab23d8a

wra-wtag added 2 commits October 1, 2025 15:22

Updated Notification model enum

fc6e0b3

Added default statuses

dd843f6

wra-wtag changed the base branch from Gems to Initiate-Rails October 2, 2025 05:18

wra-wtag added 9 commits October 2, 2025 11:19

Merge branch 'Initiate-Rails' into core-models-and-associations-based…

9952352

…-on-erd-with-tests

Updated User model by adding :trackable and :confirmable

afa7df4

fixed extra spaces

3b300e9

Fix status change detection in Job model and update Notification enum…

2de045a

… values

Merge branch 'Initiate-Rails' into core-models-and-associations-based…

c138626

…-on-erd-with-tests

Merge branch 'Initiate-Rails' into core-models-and-associations-based…

093213c

…-on-erd-with-tests

Added devise and sidekiq gem and configured them

fc14e8d

Merge branch 'Initiate-Rails' into core-models-and-associations-based…

0e448db

…-on-erd-with-tests

Update Gemfile

ec67d23

hoh-wtag suggested changes Oct 15, 2025

View reviewed changes

wra-wtag added 6 commits October 15, 2025 11:56

Fixed PR reviews

2100cb7

Fixed suggested changes in Job model

e3882d2

Fixed the suggested changes in notification model

4f6be2c

Fixed the suggested changes in Job skill and recruiter membership model

4bb0e16

Updated user skill model and deleted unnecessary gem

34d106e

Fixed test files based on the suggested updates also updated job reco…

88d2721

…mmendation model payload

		@@ -0,0 +1,32 @@
		class Application < ApplicationRecord
		belongs_to :job, counter_cache: :applications_count


		validates :job_id, uniqueness: { scope: :user_id, message: "You have already applied for this job" }

		has_one_attached :resume

		has_many :user_skills, dependent: :destroy
		has_many :users, through: :user_skills

	validates :experience_years, numericality: { greater_than_or_equal_to: 0 }
	validates :years_of_experience, numericality: { greater_than_or_equal_to: 0 }

Conversation

wra-wtag commented Sep 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Models, Associations & Database Schema Setup

Description

Changes

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

wra-wtag commented Sep 23, 2025 •

edited

Loading