Batch sender fixed2 - #181
Merged
truthixify merged 2 commits intoAug 31, 2026
Merged
Conversation
Contributor
Author
|
@truthixify, please review and merge. |
Contributor
|
Merged @stpatrickghost. Opening a fresh branch was the right call once #175 rewrote batch-sender underneath the old one; untangling that rebase would have cost more than starting clean. Thanks for sticking with it through three rounds. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Batch-sender was still emitting a single-topic ("ANNOUNCE",) event, so indexers could not apply server-side topic-3 view-tag filtering to anything sent through it.
This change routes each batch-sender transfer through the announcer contract, the same pattern stealth-splitter already uses. Announcements now use the v2 4-topic layout:
topics: ("announce", scheme_id, view_tag_bucket, metadata_kind)
data: (stealth_address, ephemeral_pub_key, metadata)
view_tag_bucket = metadata[0] as u32.
Issue #62 is an audit-doc correction only. Splitter fund_split already calls announcer_client::announce. No splitter code change.
Changes
Acceptance
Test plan
Closes #159