feat(split): add save/load templates with address-book autocomplete - #174
Open
JohnOluB wants to merge 1 commit into
Open
feat(split): add save/load templates with address-book autocomplete#174JohnOluB wants to merge 1 commit into
JohnOluB wants to merge 1 commit into
Conversation
|
@JohnOluB is attempting to deploy a commit to the truthixify's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@JohnOluB Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #155
Status: Draft / blocked
Started implementation and hit two gaps between the issue's assumed
starting state and what's actually in the repo. Opening this early to
surface them rather than guessing at replacement logic.
Blocker 1 —
src/lib/stellar/batchSend.tsdoes not existStellarSplit.tsximports from it:src/lib/currently only containsexplorer.ts. This looks like eithera branch mismatch on my end or a file missing from this checkout —
can someone confirm which branch/commit #155 was filed against?
This blocks the template feature directly: loading a saved template
needs to re-validate rows through the same path CSV paste uses, and I
don't want to reimplement
validateRowsfrom scratch and risk itsilently diverging from the real validation rules.
Blocker 2 — no existing address-book autocomplete to reuse
Acceptance criteria says the combobox should use "the ARIA pattern
already established in address-book send autocomplete." I checked:
src/store/contactsStore.tsxexists (useContacts()), but nothingin the app currently consumes it
src/components/StellarSend.tsx(the actual send UI) uses a plaintext input with a manual paste button — no combobox, no
autocomplete, no
useContactsimportrole="combobox"/aria-activedescendantusage anywhere insrc/package.json(Radix, Headless UI,downshift, react-aria are all absent)
So there's no existing pattern to reuse yet. Happy to build the first
hand-rolled ARIA combobox for this (matching the plain-Tailwind,
no-dependency style of the rest of the app) — just flagging that it'll
be new, not reused, so review expectations match.
Plan once unblocked
src/store/splitTemplatesStore.tsx— Context + localStorage,mirroring
contactsStore.tsx's pattern (done locally, ready to push)StellarSplit.tsxcontactsStoreQuestions for maintainers
batchSend.tsmissing from this branch, or was it never committed?address-book autocomplete that I should build on top of instead?