Refactor: implement "TypeCheckVisitor" for type-checking - #7
Merged
Conversation
Bugs fixed: - Control statement type checking only validated the condition type and ignored nested statement failures. - MethodWithoutParametersNode reported return-type mismatches but still returned success. - ClassAllocationNode accepted undeclared class names as valid types. How this commit fixes them: - ControlStatementNode::checkTypes now checks both condition and statement branch results, propagating failure when either side is invalid. - MethodWithoutParametersNode::checkTypes now returns failure after emitting a return-type mismatch diagnostic. - ClassAllocationNode::checkTypes now verifies the allocated class exists in the symbol table and reports an error otherwise. Tests added: - ControlStatementPropagatesStatementTypeFailure - MethodWithoutParametersReturnMismatchFailsTypeCheck - ClassAllocationRequiresDeclaredClassType Validation: - ctest --test-dir build --output-on-failure (35/35 passing).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces the old
checkTypesAPI for type-checking with a newTypeCheckVisitortype. This is similar to a previous PR, which refactored the symbol table construction #6 .