Apply ignore/whitelist list to hint notifications - #238
Merged
Conversation
The hint notification path in the poller checked snooze, finished-slot, hint-type prefs, and backfill, but never consulted the user's ignore list. The hint *history* view (process_hints_for_user) does compute isIgnored, so a hint for an ignored item was hidden in history yet still fired a push notification — matching a user report of "still getting notified for ignored items." Evaluate each hint against the item owner's game/checksum (the hinted item belongs to the item owner), using the same evaluate_item_filter_status the item-notification and history paths use, so item-group rules resolve against the correct datapackage version. Broaden the batch's group-membership lookup to include hint item-owner checksums as well. Verified against live dev data: hints for Special Rats members (Pizza Rat, Chef Rat) now suppress; non-members (Pack Rat) still notify. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #233. A user reported still getting push notifications for
ignored items after the ignore/whitelist work merged. Investigated and found
a genuine gap: the poller's hint notification path never consulted the
ignore list.
The item-notification path and the history views (both item and hint) all
evaluate ignore/whitelist rules, but the hint notification loop only
checked snooze, finished-slot, hint-type prefs, and backfill. So a hint for
an ignored item was correctly hidden from the hint history view yet still
fired a push — exactly the reported symptom.
Fix
item belongs to the item owner), via the same
evaluate_item_filter_statusused by the item-notification and history paths. This keeps notifications
consistent with the hint history view and resolves item-group rules against
the correct datapackage version.
item-owner checksums, not just received-item checksums.
this only adds suppression, it does not force-notify hints that prefs
disabled.
Verification
Tested against live dev data (Autopelago room, "Special Rats" group ignored):
Test plan
test_group_ignore_is_reflected_in_hint_historycovers the hinthistory isIgnored flag (the shared computation)
test_history_ignore_filteringsuite still passes (6 tests)test_history_sync_cursor,test_threshold_reconciliation,test_whats_newpassslot, confirm no push
🤖 Generated with Claude Code