5.1 backwards compatability #16
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should be fairly straightforward
Owner
|
Did you try this on Lua 5.1 as well as on LuaJit? Since LuaJit includes some 5.2 things that aren't in Lua 5.1.. |
replacing the assertion about the unpredictable length of a table's string representation with just a warning.
Author
|
Lua 5.1 works fine, but again the debug string for representing tables is a different length. Oh well, it does work now all tests verified for lua5.1, lua5.2, and luajit. For me, at least. I don't think a test for whether tostring({}) is a certain length is really needed... left a warning in there anyway. Could just delete that test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should be fairly straightforward