Repository navigation
target: per-workspace engines, skrog target and skrog use (#539) - #541
Merged
Merged
Conversation
A named engine is a complete, independent install under <state>\engines\<name>: its own distro, VHDX, supervisor, pipe, docker context, settings and snapshots. `skrog target create|list|remove` manages them, `skrog use <name>|local` switches docker between the shared engine, a named engine and a remote. - supervisor derives its pipe and context from its state dir and never touches the shared `skrog` context - `target:` key in skrog.yaml (not `engine:`, which holds daemon.json keys) - `skrog autostart --engine <name>`: one Run-key value per engine - engine, config and status act on the current target without --state-dir - tray follows the current target; doctor judges the disk floor across every engine's volume - shared rootfs download cache (provision.Options.CacheDir) - install source selection extracted so install and target create share it - uninstall also removes named engines and lists them in the prompt - docs/targets.md, design notes, cli-json, changelog; reference and completions regenerated; e2e stage added Known limit: binfmt_misc emulation handlers are kernel-wide, so stopping any engine deregisters them for all.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #539. Implements the design in
docs/design/per-workspace-engine.md(#140).What
A named engine is a complete, independent install under
<state>\engines\<name>: own distro, VHDX, supervisor, pipe (\.\pipe\skrog-<name>), docker context (skrog-<name>), settings and snapshots.skrog target create|list|remove,skrog use <name>|local(remote useis now the same command)skrogcontexttarget:key inskrog.yamlskrog autostart --engine <name>(one Run-key value per engine, opt-in)engine,config,statusact on the current target when--state-diris absent (skipped entirely with no named engines)installandtarget createshare itdocs/targets.md, design notes, cli-json, declarative-install, changelog; reference and completions regeneratedDifferences from the design
target:, notengine:(engine:already holds daemon.json settings)skrog uninstallalso removes named engines (prompt lists them), so "removes everything Skrog created" stays true. Running it on a named engine's own state dir is refused in favour oftarget removestatusis scoped to the current target too, since the tray reads itKnown limit
binfmt_miscemulation handlers are kernel-wide, so stopping or removing any engine deregisters them for all. Documented, not fixed.Testing
go test ./...,go vet, gofmt, link check, reference/completions-Check: passinternal/target, autostart per engine, skrogfiletarget:, doctor multi-engine disk, tray, cmd wiring and JSON shapesPerWorkspaceEngineIsIsolated(create, list, use, image isolation, remove, nothing left behind). Compiled only; not yet run against real WSL. Please run it, or review the create/use/remove paths with that in mind.internal/pipeproxycrashed once in Go's runtime with and without these changes; it passed on rerun.