Change keystore package name and add relevant dependencies.#245
Open
mpmadhavig wants to merge 4 commits intowso2:feature-remove-registry-from-keystorefrom
Open
Change keystore package name and add relevant dependencies.#245mpmadhavig wants to merge 4 commits intowso2:feature-remove-registry-from-keystorefrom
mpmadhavig wants to merge 4 commits intowso2:feature-remove-registry-from-keystorefrom
Conversation
7 tasks
|
|
||
| String keyStoreName = generateKSNameFromDomainName(); | ||
| // Use the keystore using the keystore admin | ||
| KeyStoreAdmin keystoreAdmin = new KeyStoreAdmin(tenantId, govRegistry); |
Member
There was a problem hiding this comment.
If we are removing the registry reference here, we should be able to remove all the registry imports. And thats part of the main objectives.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe
This effort will reflect the changes done to move keystore package from framework to kernel. For furthure details please refer the issue.
Related issues
When this PR should get merged to master