-
Notifications
You must be signed in to change notification settings - Fork 97
Add documentation for SSL profile failure handling at startup #2171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ravindu25
wants to merge
1
commit into
wso2:main
Choose a base branch
from
ravindu25:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove GitHub review interface artifacts from documentation.
Lines 231 and 234 contain text fragments that appear to be accidentally copied from GitHub's review interface:
"Expand commentComment on lines R160 to R167Resolved""Expand commentComment on line R170Resolved"These artifacts should be removed from the documentation.
🧹 Proposed fix to remove artifacts
Verify each finding against the current code and only fix it if needed.
In
@en/docs/install-and-setup/setup/transport-configurations/multi-https-transport.mdat line 231, Remove the accidentally copied GitHub review artifacts from the
documentation paragraph where the JVM parameter is shown: locate the snippet
containing "-Dssl.profile.skip.failures=true" and remove the stray strings
"Expand commentComment on lines R160 to R167Resolved" and "Expand commentComment
on line R170Resolved" so the parameter stands alone and the surrounding text is
clean; ensure no other occurrences remain near the same paragraph (around the
shown JVM parameter) and update any affected spacing or punctuation.