[4.7.x] Add pod.labels support to all helm charts - #259
Open
kavindasr wants to merge 2 commits into
Open
Conversation
Port of wso2#174 (merged to 4.6.x). Adds wso2.deployment.pod.labels to all five charts, allowing custom labels to be merged into the pod template labels alongside the default deployment/node/product labels. Follows the existing wso2.deployment.pod.annotations pattern. READMEs regenerated with helm-docs.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
- Note in each chart's values.yaml that the Deployment selector keys (`deployment`, plus `node` where the chart uses it) must not be overridden via wso2.deployment.pod.labels. READMEs regenerated with helm-docs. - Add the wso2.deployment.pod block (annotations + labels) to all 14 pattern values files under resources/, which had been out of sync with the charts since the pod.annotations refactor.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Port of #174 (merged to
4.6.x) so thatwso2.deployment.pod.labelsis available on this branch too.Goals
Add
wso2.deployment.pod.labelsconfiguration to all WSO2 APIM helm charts, enabling users to set custom labels for pod organization, monitoring, cost allocation, and policy enforcement.Approach
Added
pod.labels: {}tovalues.yamland updated the deployment templates to merge custom labels with the default labels in all 5 charts:all-in-one(2 instances)distributed/control-plane(2 instances)distributed/gatewaydistributed/key-managerdistributed/traffic-manager(2 instances)Implementation follows the existing
pod.annotationspattern for consistency.Template changes:
Usage example:
Release note
Added support for custom pod labels via
wso2.deployment.pod.labelsconfiguration in all helm charts.Documentation
README.mdfiles for all 5 charts regenerated withhelm-docs(v1.14.2).Automation tests
helm lintpasses for all 5 charts;helm templateverified with both default values (output identical to before) and custompod.labels(labels correctly merged into the pod template).Security checks
Related PRs
4.6.x)Migrations (if applicable)
N/A - Backward compatible. Default value is an empty map
{}, producing identical output to previous versions.Test environment