Skip to content

Fix tests#1494

Merged
kaumini merged 24 commits into
wso2:mainfrom
kaumini:main
Jun 3, 2026
Merged

Fix tests#1494
kaumini merged 24 commits into
wso2:mainfrom
kaumini:main

Conversation

@kaumini

@kaumini kaumini commented May 29, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@kaumini kaumini requested a review from rosensilva as a code owner May 29, 2026 05:27
@kaumini kaumini added the Checks/Run MI UI Tests Force run MI UI tests label May 29, 2026
@coderabbitai

coderabbitai Bot commented May 29, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review
📝 Walkthrough

Walkthrough

This PR adjusts CI and repository configs: the GitHub Actions build workflow disables automatic Rush install and adds an explicit dependency installation step after submodule initialization; packages/mi-extension/.gitignore is refined to track resources/images/ while excluding a specific icon; PNPM override logic and package.json now pin tmp to 0.2.6; packages/mi-language-server bumps commons.io.version to 2.14.0; the Trivy workflow step is disabled; and onboarding logic in isMISetup was scoped to apply cached MI paths.

Sequence Diagram(s)

sequenceDiagram
  participant GitHubAction
  participant SubmoduleInit
  participant InstallScript
  participant RushSetup
  GitHubAction->>SubmoduleInit: Init submodules
  SubmoduleInit->>InstallScript: run node common/scripts/install-run-rush.js install
  InstallScript->>RushSetup: prepare dependencies (rush-install disabled)
Loading
🚥 Pre-merge checks | ✅ 2 | ❌ 3

❌ Failed checks (1 warning, 2 inconclusive)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Title check ❓ Inconclusive The title 'Fix tests' is vague and generic, lacking specificity about which tests are being fixed or what changes constitute the fix. Replace with a more descriptive title that specifies the nature of the test fixes, such as identifying the particular test failures or underlying issues being addressed.
Description check ❓ Inconclusive No pull request description was provided, making it impossible to assess whether the description relates to the changeset. Add a description that explains which tests are being fixed, why they were failing, and how the changes address the failures.
✅ Passed checks (2 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.github/workflows/build.yml:
- Around line 130-131: The Trivy step "Run Trivy vulnerability scanner" is
hard-disabled by the literal if: ${{ false }}; replace that with a workflow
input guard (e.g., add an input like enableSecurityScan with a default
true/false in the workflow's inputs) and change the step condition to check that
input (for example use if: ${{ inputs.enableSecurityScan == 'true' }} or
equivalent for your trigger), so the scan can be re-enabled or explicitly
toggled per run instead of always skipped.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 518540ab-ecd4-444f-ad45-1d098f2d6abc

📥 Commits

Reviewing files that changed from the base of the PR and between 80e51fc and 3dd082b.

⛔ Files ignored due to path filters (1)
  • common/config/rush/pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (1)
  • .github/workflows/build.yml

Comment thread .github/workflows/build.yml Outdated
@kaumini kaumini requested a review from gigara June 3, 2026 09:16
@kaumini kaumini merged commit 509588f into wso2:main Jun 3, 2026
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Checks/Run MI UI Tests Force run MI UI tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants