Fix issues with overflow of uint16 for very large acquisition#49
Open
chaithyagr wants to merge 2 commits intowtclarke:masterfrom
Open
Fix issues with overflow of uint16 for very large acquisition#49chaithyagr wants to merge 2 commits intowtclarke:masterfrom
chaithyagr wants to merge 2 commits intowtclarke:masterfrom
Conversation
added 2 commits
June 27, 2025 11:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you so much for the wonderful package.
We noticed that for some very large acquisitions with number of lines > 65536, we dont read the entire data.
This is a minor fix. Please let mw know if theres something better we could do.