Skip to content

ci: restore extended gate, integration tests, and quality hardening - #31

Merged
wukongnotnull merged 8 commits into
mainfrom
ci-quality-hardening
Sep 3, 2026
Merged

ci: restore extended gate, integration tests, and quality hardening#31
wukongnotnull merged 8 commits into
mainfrom
ci-quality-hardening

Conversation

@wukongnotnull

@wukongnotnull wukongnotnull commented Sep 3, 2026

Copy link
Copy Markdown
Owner

Who is submitting this PR? (required)

Field Value
Your model + version Composer (Cursor agent router)
Harness + version Cursor IDE, agent CLI 2026.08.11-e8db854
All plugins installed wukong-code (local plugin), cursor-public frontend-design, claude-plugins-official cache
Human partner who reviewed this diff wukong — requested the work, accepted the improvement plan, reviewed commits incrementally, code-reviewed PR #31, and asked to apply review fixes

What problem are you trying to solve?

The repository had no GitHub Actions CI after the test workflow was removed (2026-08-12-1239-remove-ci-workflow.md), so PR quality depended entirely on contributors running tests locally. The first CI run on this PR failed because ubuntu-latest lacks rg, which several core tests require. Cursor had no deterministic plugin wiring tests in the core suite. README language-pack evidence for JavaScript/TypeScript did not match recapture-15 eval drafts. Brainstorming context exploration could precede TDD testing.md reads (recapture-15 blocking failure). Spec/plan reviewer templates existed but were not wired into skills.

Why restore CI now?

The August removal plan preserved local npm test / npm run test:extended but dropped automation when maintainers wanted fewer moving parts. Since then the extended suite (brainstorm-server + Antigravity) runs cleanly locally, and this PR adds a test-runner contract so suite drift is caught statically. Restoring extended CI reinstates the gate described in 2026-08-12-1209-ci-extended-gate.md with rg installed on the runner.

What does this PR change?

Restores extended CI on PR/push (with ripgrep), adds test-runner contract and Cursor manifest tests, documents tiered eval automation with pinned static manifest workflow, tracks eval infrastructure plans, tightens TDD/brainstorming fixture boundaries for recapture-16 prep, wires subagent document review loops (with no-subagent fallback), and aligns README evidence links across locales.

Is this change appropriate for the core library?

Yes. Core plugin infrastructure, skill behavior constraints, and documentation — not a standalone plugin. No new runtime dependencies. Skill wording changes are minimal hard-constraint additions; publication is not claimed. Recapture-16 behavioral matrix is follow-up work.

What alternatives did you consider?

  • Core-only CI gate: rejected — extended suite already includes brainstorm-server/Antigravity regressions.
  • Replace rg with grep in tests: rejected for this PR — install rg in CI to match local dev and existing test scripts.
  • Inline-only document review: rejected — templates existed unused; added subagent-less fallback for Pi-like harnesses.
  • Deleting all untracked eval plans: tracked infrastructure plans, removed superseded Aug 18–30 recapture duplicates only.

Does this PR contain multiple unrelated changes?

Related hardening pass (CI, eval honesty, recapture-16 prep). Skill changes remain in this PR but without claiming publication readiness; maintainer may still prefer splitting skill commits — human partner accepts that risk for now.

Existing PRs

Environment tested

Harness Version Model Notes
Cursor (local shell) IDE N/A npm test + npm run test:extended pass
GitHub Actions ubuntu-latest, Node 22 N/A ripgrep installed; extended gate (post-fix commit)

New harness support

N/A — deterministic Cursor plugin wiring tests only.

Evaluation

  • Initial prompt: project optimization audit → accepted recommendations → incremental commits → PR → code review → review fixes.
  • LLM behavioral cohort sessions after skill changes: 0 (recapture-16 follow-up).
  • Deterministic: npm test, npm run test:extended pass locally after each commit.

Language-pack evidence

  • JS/TS: Experimental in core; recapture-15 drafts show blocking families; Planned for publication — not flipped here.
  • Static contracts updated for TDD/brainstorming phrases.
  • Human language reviewer: pending.

Rigor

  • writing-skills adversarial eval for skill changes (deferred to recapture-16 PR)
  • Static contract tests for new skill phrases
  • Did not modify Red Flags / rationalization / "human partner" tables

Human review

  • Human reviewed complete diff and code review findings before submission

wukongnotnull and others added 8 commits September 3, 2026 22:22
Re-add GitHub Actions extended suite on PR/push, add test-runner contract
and Cursor manifest checks, and link JS/TS README evidence to recapture-15 drafts.

Co-authored-by: Cursor <cursoragent@cursor.com>
Defer fixture src/test exploration during brainstorming when TDD applies,
and treat late switches after brainstorming context reads as TDD failures.

Co-authored-by: Cursor <cursoragent@cursor.com>
Wire brainstorming and writing-plans to use their reviewer prompt templates
after inline self-review instead of stopping at checklist-only review.

Co-authored-by: Cursor <cursoragent@cursor.com>
Add publication and Cursor eval harness isolation plans; remove intermediate
Aug 18–30 js-ts recapture duplicates superseded by later tracked plans.

Co-authored-by: Cursor <cursoragent@cursor.com>
Document eval harness setup with a three-tier automation model and validate
language-guidance scenario manifests weekly without API credentials.

Co-authored-by: Cursor <cursoragent@cursor.com>
Link TypeScript and JavaScript rows to recapture-15 drafts across localized
READMEs and clarify that publication eval gates remain pending.

Co-authored-by: Cursor <cursoragent@cursor.com>
Install ripgrep in GitHub Actions, pin evals-static harness SHA, add
subagent-less review fallbacks, and align writing-plans handoff wording.

Co-authored-by: Cursor <cursoragent@cursor.com>
GNU tar rejects BSD --uid/--gid flags used when building Codex tar.gz
archives; select --owner/--group on GNU tar and keep BSD flags on macOS.

Co-authored-by: Cursor <cursoragent@cursor.com>
@wukongnotnull
wukongnotnull merged commit f904879 into main Sep 3, 2026
2 checks passed
@wukongnotnull
wukongnotnull deleted the ci-quality-hardening branch September 3, 2026 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant