feat: persist confirmed grilling records as specs before writing-plans - #32
Merged
Conversation
Confirmed grilling records were conversation-only; this design archives them as specs and gates writing-plans on file review so the next process has a durable input. Co-authored-by: Cursor <cursoragent@cursor.com>
The first spec draft left Completion Gate, Quick Reference, and the router plan-mode brainstorming line unspecified, which would let a plan miss required edits. Co-authored-by: Cursor <cursoragent@cursor.com>
Replacing the whole CONFIRMATION-GATE block would drop the read-only rule the persist change still requires. Co-authored-by: Cursor <cursoragent@cursor.com>
Confirmed grilling records need a durable spec and a writing-plans gate; this plan is the TDD sequence for that skill change. Co-authored-by: Cursor <cursoragent@cursor.com>
Task 3 line ranges would drift after the first edit, and Task 4 omitted the GREEN eval append path. Co-authored-by: Cursor <cursoragent@cursor.com>
The old confirmation probe scored a next-step menu. The new contract needs a failing resident scenario before the skill text can change. Co-authored-by: Cursor <cursoragent@cursor.com>
Current grilling stops at a next-step menu after confirmation, so the new handoff contract is still failing. Co-authored-by: Cursor <cursoragent@cursor.com>
Confirmation left the decision record in chat. HANDOFF now archives the eight-section record and waits for file review before writing-plans. Co-authored-by: Cursor <cursoragent@cursor.com>
The router omitted grilling and treated plan mode as brainstorming-only, which fought the confirmed-record archive path. Co-authored-by: Cursor <cursoragent@cursor.com>
The 2026-07-26 handoff conclusion is obsolete for this path; this report is the RED/GREEN evidence for persist then writing-plans. Co-authored-by: Cursor <cursoragent@cursor.com>
The first GREEN run read in-repo spec/plan/rubric files. Isolated recapture plus full transcripts are the evidence that persist-first comes from the skill text. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Who is submitting this PR? (required)
wukong-code; Cursor skillsautomate,autopilot,canvas,create-hook,create-rule,create-skill,loop,new-repo,origin,review-bugbot,review-security,sdk,share,split-to-prs,statusline,update-cursor-settings; cachedfrontend-design,x-api-mcp-guide; user skillsbeautify-github-readme,skill-creator,wk-gzh-*,wk-html-slides-amber-classified,wk-video-cover-gen,wk-video-script; MCP GitHub, X, fetch, Firecrawl, and others present in the sessionwukongnotnull) — reviewed the spec, approved the plan, chose inline execution, then chose push-and-PRWhat problem are you trying to solve?
After a grilling interview, the confirmed Shared-Understanding Record stayed in the chat.
writing-plansneeds a durable spec. The old HANDOFF asked one next-step question and forbade any automatic process, so the consensus often never became a file and never reached an implementation plan.using-wukong-codealso omittedgrillingfrom the Scope routing table and the primary-process list, and "Before entering plan mode" forced brainstorming. Agents that loaded the router after confirmation either stalled or treated persist → plan as a forbidden auto-chain.This was a real session request: after grilling, archive the consensus as a spec, then write the implementation plan.
What does this PR change?
grillingHANDOFF now writes the confirmed eight-section record todocs/wukong-code/specs/YYYY-MM-DD-HHmm-<topic>-design.md, commits it, and waits for file review. Approval of the written spec — not confirmation of the in-chat record — authorizeswriting-plans.using-wukong-codenamesgrillingand allows that handoff. Resident scenarios M4–M7 and U1 plus RED/GREEN eval evidence are included.Is this change appropriate for the core library?
grillingfor programming decisions and then needswriting-plans.writing-plansonly after file approval; early-stop still conversation-only; router persist-first). Seedocs/wukong-code/evals/2026-09-08-grilling-spec-handoff.md.What alternatives did you consider?
using-wukong-codestill says stop after confirmation / force brainstorming before plan mode.writing-plans. Drops the written-spec review gate.Chose grilling + minimum router alignment.
Does this PR contain multiple unrelated changes?
No. One behavior path: persist a confirmed grilling record as a spec, then enter
writing-plansafter file approval. Scenario, skill, router, spec, plan, and eval files are that path.The branch was rebased
--onto origin/mainso five unpushed localmaincommits (language-guidance / eval-plan leftovers) are not in this PR.Existing PRs
feat: add programming grilling skill#13 added grilling with conversation-only records and a next-step HANDOFF. This PR keeps the interview contract and changes only the post-confirmation terminal path. No open PR covers persist-spec then
writing-plans. Search also checkedgrilling persist,grilling writing-plans, andShared-Understanding/handoff.Environment tested
RED/GREEN probes used fresh Cursor general-purpose subagents pointed at candidate skill paths.
New harness support (required if this PR adds a new harness)
Not applicable. This PR does not add a harness.
Clean-session transcript for "Let's make a react todo list"
Evaluation
writing-plansfrom the in-chat record with no file. RED M7 already passed (early stop, no file). GREEN M4/M5 wrote and committed the spec and stopped for review. GREEN M6 loadedwriting-plansonly after按这个写计划. GREEN M7 still emitted a partial record with no persist. GREEN U1 persisted first with both skills loaded.Raw evidence:
docs/wukong-code/evals/raw/2026-09-08-grilling-spec-handoff/red.mdandgreen.md.Language-pack evidence
Rigor
wukong-code:writing-skillsandcompleted adversarial pressure testing (paste results below)
rationalizations, "human partner" language) without extensive evals
showing the change is an improvement
Pressure tests after the skill edit:
按这个写计划before a written spec was the RED failure; GREEN requires persist first, thenwriting-plansonly after file approval (M6).Write it to a file only when explicitly,ask exactly one next-step,Take no next action) are absent fromskills/grilling/SKILL.mdat HEAD7f65231.tests/skills/test-skill-slim-gates.shSTATUS: PASSED at HEAD7f65231.Turn Contract, Red Flags, and "human partner" wording in grilling were not rewritten. Only CONFIRMATION-GATE's leftover authorization sentence, HANDOFF, Completion Gate write rule, Early Stop persist prohibition, and Quick Reference rows changed.
Human review
Human partner approved the design spec, approved the implementation plan, watched inline execution, and selected finish option 2 (push and create a Pull Request).
Made with Cursor