Skip to content

Fix too early specification of generic types #1130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Frotty merged 1 commit into from
Dec 20, 2025
Merged

Fix too early specification of generic types #1130

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...cript/src/main/java/de/peeeq/wurstscript/translation/imtranslation/EliminateGenerics.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -582,12 +582,12 @@ public void visit(ImTypeArgument ta) {
@Override
public void visit(ImNull e) {
ImType newT = transformType(e.getType(), generics, typeVars);
newT = specializeType(newT);
e.setType(newT);

ImExpr safe = specializeNullInitializer(e, newT);
if (safe != e) {
e.replaceBy(safe);
return;
}
super.visit(e);
}
Expand Down
30 changes: 30 additions & 0 deletions de.peeeq.wurstscript/src/test/java/tests/wurstscript/tests/GenericsWithTypeclassesTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2023,5 +2023,35 @@ public void fullArrayListTest() throws IOException {
testAssertOkFileWithStdLib(new File(TEST_DIR + "arrayList.wurst"), true);
}

@Test
public void genericNullComparison() {
testAssertOkLinesWithStdLib(true,
"package test",
"import NoWurst",
"import ClosureTimers",
"native testSuccess()",
"public class Reference<T:>",
" T val",
" construct(T val)",
" this.val = val",
" function into() returns T",
" let rval = val",
" destroy this",
" return rval",
"",
"var r = new Reference(0.0)",
"",
"init",
" // force member access on the global",
" doAfter(.1) ->",
" r.val = 1.0",
" if r != null and not r == null and r.into() == 1.0",
" testSuccess()",
" testSuccess() // to make compiler happy",
"endpackage"
);
}



}
Loading