fix(feed): stop advertising leftover Highlighty Part 2 404 - #32
Draft
wustep wants to merge 1 commit into
Draft
Conversation
The posts collection still marks Rapid Prototyping: Highlighty (Part 2) as public, so /feed advertised /rapid-prototyping-highlighty-part-2. That slug is hidden from home and /writing, so the site 404s. Skip feed items that would not resolve the same way page routes do.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was wrong
/feedstill lists Rapid Prototyping: Highlighty (Part 2) at/rapid-prototyping-highlighty-part-2. That post is marked Public in the Notion posts collection (so RSS picks it up), but it is hidden from home and/writing, so it is not in the committed page index. Visiting the URL is a soft 404:Production 404 for /rapid-prototyping-highlighty-part-2
This is leftover from the Highlighty article pair. Part 1 (
/rapid-prototyping-highlighty) is real and already fixed in #24. Part 2 is an unpublished leftover that subscribers still get as a dead link.Why it matters
RSS is a public listing. Advertising a URL that 404s is worse than omitting a hidden draft. The feed description for Part 2 also falls back to the generic site tagline (
Software Engineer, San Francisco, CA), which is another leftover-article smell.What changed
Feed items are now skipped unless
/<slug>would resolve the same way page routes do: committed index / URL overrides, then collection slugs from override pages like/writing. Hidden leftover posts stay out of the feed. Real hidden-from-home posts that are on/writing(Part 1) still resolve and still appear.Test plan
isResolvablePageSlug(index hit, writing-collection hit, leftover Part 2 miss)GET /feedno longer containsrapid-prototyping-highlighty-part-2/feedstill includes/rapid-prototyping-highlighty,/oct-25,/philosophy/rapid-prototyping-highlighty-part-2still 404s (intentional; this PR does not publish the leftover page)Notion Test Page ID
2bc5cb08cf2c81639fb3f549654b6a7c(Highlighty Part 2 — leftover, 404s on the site)To show artifacts inline, enable in settings.