Skip to content

Fix player resource switch search#18

Merged
wxst merged 1 commit into
mainfrom
fix/resource-switch-modal
May 11, 2026
Merged

Fix player resource switch search#18
wxst merged 1 commit into
mainfrom
fix/resource-switch-modal

Conversation

@wxst

@wxst wxst commented May 11, 2026

Copy link
Copy Markdown
Owner

Summary

  • make js/search.js self-contained for player resource switching by owning the title relevance helpers it calls
  • fall back to default selected sources on the player page when no local source selection exists
  • show clear empty states when no switchable resources are selected or found
  • bump release metadata to 1.2.13

Root Cause

The player page loads js/search.js but not the homepage js/app.js. After the search relevance filter was added in app.js, searchByAPIAndKeyWord() on the player page could hit a missing filterResultsByQuery helper and return empty results for every source.

Tests

  • node --test test\\libretv-defaults.test.mjs --test-name-pattern "player resource switch can search without loading homepage app script"
  • npm test
  • node --check js\\search.js js\\player.js js\\app.js
  • npm run smoke:browser with LIBRETV_BASE_URL=http://127.0.0.1:18080

@wxst wxst merged commit 25f9911 into main May 11, 2026
1 check passed
@wxst wxst deleted the fix/resource-switch-modal branch May 11, 2026 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant