Skip to content

fix(lint): clear 7 ESLint errors blocking Release pipeline#20

Merged
asachs01 merged 1 commit into
mainfrom
fix/lint-cleanup
May 14, 2026
Merged

fix(lint): clear 7 ESLint errors blocking Release pipeline#20
asachs01 merged 1 commit into
mainfrom
fix/lint-cleanup

Conversation

@asachs01
Copy link
Copy Markdown
Member

Summary

Clears 7 ESLint errors that started failing the Release workflow on 2026-05-13 20:03Z (when PR #19 triggered the first run on this CI surface).

Error File Fix
no-unused-vars (MCP SDK imports) src/worker.ts Removed — Workers transport adapter not yet wired (file currently returns 501). Comment left as re-add breadcrumb.
prefer-const on closedOnly src/domains/tickets.ts letconst (auto-fix)
no-unused-vars on handler1 src/__tests__/navigation.test.ts Renamed _handler1 (return value not asserted, only side-effect matters)

Why now

Coordinated CI failure across 3 MCP repos (cipp/halopsa/liongard) at 2026-05-13 20:03-04Z after each repo's id-token-grant fix landed and triggered first Release run. Liongard tracked separately at wyre-technology/liongard-mcp#18.

Test plan

  • npm run lint clean
  • npm run build clean
  • npm test — all 94 tests pass
  • CI green

- src/worker.ts: drop unused MCP SDK imports (Workers transport adapter
  not yet wired; file currently returns 501 for /mcp). Comment left as
  re-add breadcrumb when adapter lands.
- src/domains/tickets.ts: prefer-const on closedOnly (auto-fix).
- src/__tests__/navigation.test.ts: rename handler1 → _handler1 (return
  value not asserted, only side-effect of cache population matters).

Verified: npm run lint clean, npm run build clean, all 94 tests pass.
Copy link
Copy Markdown

@claude claude Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Code review skipped — your organization's overage spend limit has been reached.

Code review is billed via overage credits. To resume reviews, an organization admin can raise the monthly limit at claude.ai/admin-settings/claude-code.

Once credits are available, push a new commit or reopen this pull request to trigger a review.

@asachs01 asachs01 merged commit f10bd2b into main May 14, 2026
10 checks passed
@asachs01 asachs01 deleted the fix/lint-cleanup branch May 14, 2026 00:11
@github-project-automation github-project-automation Bot moved this from Todo to Done in MSP Claude Plugins May 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant