fix(lint): clear 7 ESLint errors blocking Release pipeline#20
Merged
Conversation
- src/worker.ts: drop unused MCP SDK imports (Workers transport adapter not yet wired; file currently returns 501 for /mcp). Comment left as re-add breadcrumb when adapter lands. - src/domains/tickets.ts: prefer-const on closedOnly (auto-fix). - src/__tests__/navigation.test.ts: rename handler1 → _handler1 (return value not asserted, only side-effect of cache population matters). Verified: npm run lint clean, npm run build clean, all 94 tests pass.
There was a problem hiding this comment.
Code review is billed via overage credits. To resume reviews, an organization admin can raise the monthly limit at claude.ai/admin-settings/claude-code.
Once credits are available, push a new commit or reopen this pull request to trigger a review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Clears 7 ESLint errors that started failing the Release workflow on 2026-05-13 20:03Z (when PR #19 triggered the first run on this CI surface).
no-unused-vars(MCP SDK imports)src/worker.tsprefer-constonclosedOnlysrc/domains/tickets.tslet→const(auto-fix)no-unused-varsonhandler1src/__tests__/navigation.test.ts_handler1(return value not asserted, only side-effect matters)Why now
Coordinated CI failure across 3 MCP repos (cipp/halopsa/liongard) at 2026-05-13 20:03-04Z after each repo's id-token-grant fix landed and triggered first Release run. Liongard tracked separately at wyre-technology/liongard-mcp#18.
Test plan
npm run lintcleannpm run buildcleannpm test— all 94 tests pass