fix: correct packaging exports so CJS/ESM consumers resolve#3
Merged
Conversation
… map package.json main/exports point to ./dist/index.cjs and ./dist/index.d.cts, but without "type": "module" tsup emitted index.js (CJS) and index.mjs (ESM), breaking require() of the published package. Adding "type": "module" makes tsup emit index.js (ESM), index.cjs (CJS), index.d.ts and index.d.cts, which match the existing exports map. Also add .eslintrc.json (replicated from sibling node-superops) so `npm run lint` resolves a config instead of erroring.
- npm audit fix (non-breaking lockfile updates) - Rewrite CHANGELOG.md in consistent Keep a Changelog format, correct package scope to @wyre-technology/node-ninjaone - Raise Node baseline to >=22: engines, tsup target node22, @types/node ^22, CI matrix Node 22 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
asachs01
force-pushed
the
fix/packaging-exports
branch
from
f57b88d to
29fd913
Compare
github-actions Bot
pushed a commit
that referenced
this pull request
May 20, 2026
## [1.1.1](v1.1.0...v1.1.1) (2026-05-20) ### Bug Fixes * correct packaging exports so CJS/ESM consumers resolve ([#3](#3)) ([1f23f92](1f23f92))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Critical packaging fix plus tooling cleanup.
Critical: packaging exports
"type": "module"topackage.json. Without it,tsupemits.cjs/.d.ctsartifacts but theexportsmap could not correctly resolve them — CJS consumers (andrequire()of the package) were broken. Withtype: modulethe build emitsindex.js/index.cjs/index.d.ts/index.d.ctsmatching theexportsmap exactly.Other changes
.eslintrc.json(TypeScript ESLint config) sonpm run lintworks.@asachs01→@wyre-technologyscope, adds compare links.>=22—engines,tsuptargetnode22,@types/node^22, CI matrix to Node 22 only.npm audit fixapplied topackage-lock.json.Verification
npm run build— green;dist/containsindex.js,index.cjs,index.d.ts,index.d.cts.npm test— 79 tests passing.npm run lint— 0 errors (4 pre-existing non-null-assertion warnings in test fixtures).