fix(health): shallow unauthenticated /health liveness probe#13
Merged
Conversation
/health called getCredentials() and returned 503 when no process-wide
credentials were set. In gateway mode (AUTH_MODE=gateway) credentials
only arrive per-request via headers, so /health always 503'd, failing
the Azure liveness probe and crash-looping the container.
Make /health (and new /healthz alias) return 200 {"status":"ok"}
with no credential check. Same fix already applied to mimecast-mcp,
ironscales-mcp, spamtitan-mcp and threatlocker-mcp.
Bumps version to 1.0.1.
The CI Test job runs 'npm run lint' (eslint src --ext .ts) but the repo never had an ESLint config file, so lint exited with code 2 and failed all three Node matrix jobs. Add the canonical fleet .eslintrc.json (matching autotask-mcp et al.). The @typescript-eslint parser/plugin were already in devDependencies. Lint now passes clean with no warnings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
gwp-proofpointACA revision was crash-looping. The container boots fine, then logs[WARN] Missing credentialsevery ~15-30s followed by[INFO] Shutting down....Root cause:
GET /healthrangetCredentials()and returned 503 when no process-wide credentials were set. In gateway mode (AUTH_MODE=gateway) credentials only arrive per-request via headers, so/healthalways 503'd. The Azure liveness probe (GET /health, every 30s) failed and Azure SIGTERM-killed the container in a loop.This is the identical bug already fixed in mimecast-mcp, ironscales-mcp, spamtitan-mcp and threatlocker-mcp.
Fix
/health(and new/healthzalias) is now a shallow, unauthenticated handler returning200 {"status":"ok"}— nogetCredentials(), no upstream calls.Fixedentry.Verification
curl /health->200,curl /healthz->200withAUTH_MODE=gateway.ghcr.io/wyre-technology/proofpoint-mcp:1.0.1+:latest.gwp-proofpointinmcp-gateway-prod; new revisiongwp-proofpoint--0000001is Healthy / RunningAtMaxScale.