-
Notifications
You must be signed in to change notification settings - Fork 479
Convert Chinese comments and documentation to English #552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert Chinese comments and documentation to English #552
Conversation
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Comment |
Co-authored-by: wysaid <1430725+wysaid@users.noreply.github.com>
Co-authored-by: wysaid <1430725+wysaid@users.noreply.github.com>
Co-authored-by: wysaid <1430725+wysaid@users.noreply.github.com>
Co-authored-by: wysaid <1430725+wysaid@users.noreply.github.com>
Co-authored-by: wysaid <1430725+wysaid@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR converts Chinese comments, documentation, and copyright headers to English across 84 files to improve international accessibility. The changes preserve all functional code while standardizing the codebase language.
Key changes:
- Copyright headers: Removed Chinese year character "年" from dates (e.g.,
2016年→2016) - Technical comments: Translated shader descriptions, GL function documentation, and implementation notes in C++ files
- Java code: Converted comments in view classes, native wrappers, and assertion messages to English
Reviewed changes
Copilot reviewed 63 out of 63 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| library/src/main/jni/interface/cgeVideoPlayer.h | Translated initialization method comment |
| library/src/main/jni/interface/cgeVideoEncoder.h | Translated encoder description and video save/discard comments |
| library/src/main/jni/interface/cgeVideoEncoder.cpp | Translated audio caching, encoding operation, and time measurement comments |
| library/src/main/jni/interface/cgeUtilFunctions.cpp | Translated time utility function comment |
| library/src/main/jni/interface/cgeFrameRendererWrapper.cpp | Translated dangerous operation warning comment |
| library/src/main/jni/interface/cgeFrameRenderer.h | Translated frame rendering interface documentation including texture handling and threading notes |
| library/src/main/jni/interface/cgeFrameRenderer.cpp | Translated framebuffer and initialization comments |
| library/src/main/jni/interface/cgeFrameRecorderWrapper.h | Translated video recording API comment |
| library/src/main/jni/interface/cgeFrameRecorderWrapper.cpp | Translated API comment and beauty effect log message |
| library/src/main/jni/interface/cgeFrameRecorder.h | Translated video recording class documentation including sync, buffering, and threading descriptions |
| library/src/main/jni/interface/cgeFFmpegNativeLibrary.h | Translated ffmpeg registration comment |
| library/src/main/jni/interface/cgeFFmpegHeaders.h | Translated dependency warning comment |
| library/src/main/jni/custom/*.{h,cpp} | Removed Chinese year character from copyright headers (8 files) |
| library/src/main/jni/cge/filters/cgeWaveformFilter.cpp | Translated transparency comment |
| library/src/main/jni/cge/filters/cgeSaturationAdjust.cpp | Translated precision handling comment |
| library/src/main/jni/cge/filters/cgeMultipleEffects.{h,cpp} | Translated blend intensity, texture loader, and parsing error comments |
| library/src/main/jni/cge/filters/cgeMinValueFilter.cpp | Translated OpenGL ES compatibility comment |
| library/src/main/jni/cge/filters/cgeMidValueFilter.cpp | Translated OpenGL ES compatibility comment |
| library/src/main/jni/cge/filters/cgeLookupFilter.h | Translated LUT filter description |
| library/src/main/jni/cge/filters/cgeLiquifyFilter.{h,cpp} | Translated liquify tool descriptions and geometric calculation comments |
| library/src/main/jni/cge/filters/cgeLerpblurFilter.cpp | Translated texture precision and compatibility comments |
| library/src/main/jni/cge/filters/cgeDataParsingEngine.cpp | Translated buffer management and parsing comments |
| library/src/main/jni/cge/filters/cgeCurveAdjust.h | Translated structure hierarchy comment |
| library/src/main/jni/cge/filters/cgeColorMappingFilter.h | Translated color mapping documentation |
| library/src/main/jni/cge/filters/cgeBrightnessAdjust.cpp | Translated precision priority comment |
| library/src/main/jni/cge/filters/cgeBlendFilter.cpp | Translated blend mode ordering comment |
| library/src/main/jni/cge/common/cgeTextureUtils.cpp | Translated mask handling comments |
| library/src/main/jni/cge/common/cgeImageFilter.cpp | Translated attribute binding comment |
| library/src/main/jni/cge/common/cgeGlobal.{h,cpp} | Translated global initialization and GL support comments |
| library/src/main/jni/cge/common/cgeGLFunctions.h | Translated callback documentation and texture management notes |
| library/src/main/jni/cge/common/cgeCommonDefine.h | Translated texture resource constraints and blend mode comments |
| library/src/main/java/org/wysaid/view/*.java | Translated initialization, listener setup, and callback comments (4 files) |
| library/src/main/java/org/wysaid/texUtils/*.java | Translated initialization comments (2 files) |
| library/src/main/java/org/wysaid/nativePort/*.java | Translated blend filter, recording, and face tracker comments (4 files) |
| library/src/main/java/org/wysaid/myUtils/*.java | Translated face detection and file path comments (2 files) |
| library/src/main/java/org/wysaid/common/*.java | Translated context and attribute binding comments (2 files) |
| library/src/main/java/org/wysaid/algorithm/AlgorithmUtil.java | Translated algorithm directory description |
| cgeDemo/src/main/java/org/wysaid/cgeDemo/*.java | Translated buffering, callback, and effect comments (3 files) |
| _codeql_detected_source_root | Added CodeQL source root marker |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@copilot 你错误添加了 codeql 相关的文件, 请忽略掉 |
Co-authored-by: wysaid <1430725+wysaid@users.noreply.github.com>
* Initial plan * Convert Chinese comments to English in C++ files Co-authored-by: wysaid <1430725+wysaid@users.noreply.github.com> * Convert Chinese comments to English in filter and common files Co-authored-by: wysaid <1430725+wysaid@users.noreply.github.com> * Convert Chinese comments to English in Java and remaining files Co-authored-by: wysaid <1430725+wysaid@users.noreply.github.com> * Fix remaining Chinese strings identified by code review Co-authored-by: wysaid <1430725+wysaid@users.noreply.github.com> * Complete internationalization improvements Co-authored-by: wysaid <1430725+wysaid@users.noreply.github.com> * Remove CodeQL artifact and add to gitignore Co-authored-by: wysaid <1430725+wysaid@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: wysaid <1430725+wysaid@users.noreply.github.com>
Internationalization Improvements
This PR successfully converts all Chinese comments, logs, and documentation to English throughout the codebase to improve project internationalization.
Completed Tasks:
Summary of Changes:
Impact:
✅ Improved code readability for international developers
✅ Standardized documentation language across the entire codebase
✅ All tests passing and no security issues
✅ Ready for review and merge
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.