Skip to content

Build variants#39

Closed
wagnerb4 wants to merge 7 commits intox0b:master-x0bfrom
kaiwinter:build-variants
Closed

Build variants#39
wagnerb4 wants to merge 7 commits intox0b:master-x0bfrom
kaiwinter:build-variants

Conversation

@wagnerb4
Copy link
Copy Markdown

@x0b
Copy link
Copy Markdown
Owner

x0b commented Jan 23, 2020

Is there a chance that this will be merged any time soon, because I would really like to have this App in the F-Droid store?

I would also like to have the app on F-Droid. However, my fork is neither on a technical nor on a legal perspective compatible with that PR.

Would you be willing to prepare a new PR? I currently lack the time for major changes, so F-Droid is really far down on the roadmap.

@x0b x0b added the ✨ Enhancement New feature or request label Jan 23, 2020
@wagnerb4
Copy link
Copy Markdown
Author

Is there a chance that this will be merged any time soon, because I would really like to have this App in the F-Droid store?

I would also like to have the app on F-Droid. However, my fork is neither on a technical nor on a legal perspective compatible with that PR.

Would you be willing to prepare a new PR? I currently lack the time for major changes, so F-Droid is really far down on the roadmap.

I currently don't have much time either. When I have some time I'll prepare the PR, but I am not promising anything.

@x0b
Copy link
Copy Markdown
Owner

x0b commented Feb 27, 2020

I actually think it would be much easier to place this on a "pure oss" branch with firebase integration removed - which could cut down massively on the code duplication in this PR. Also, I already replaced Firebase Notifications with a GitHub API call, but we would need to make the update checks opt-in by default to comply with F-Droid policy.

Also, since F-Droid does not support build secrets we can't work around hostile providers (like Yandex) with our own OAuth secrets - so the F-Droid would definitely be a "lite" version.

@x0b
Copy link
Copy Markdown
Owner

x0b commented Mar 19, 2020

Update: I've added a oss branch with firebase/gms removed. This should be ready for RFP now.

Edit: RFP is in progress.

@x0b x0b mentioned this pull request Mar 23, 2020
@x0b
Copy link
Copy Markdown
Owner

x0b commented Mar 27, 2020

I'm going to close this now since the changes proposed here have been included and an RFP is in progress.

@x0b x0b closed this Mar 27, 2020
Repository owner deleted a comment from CLAassistant Apr 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

✨ Enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants