Let people see how their investments have moved - #15
Conversation
The investments tab now has the same daily line as net worth, defaulting to total portfolio value. A picker (and clicking a holding or account) focuses the series on one position or account. Daily snapshots record holdings so that history can grow, and older net-worth account balances fill the gap until those snapshots exist. Co-authored-by: danielxu0307 <danielxu0307@gmail.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Main's last commit left these two markdown files unformatted, and prettier --check fails the whole pipeline before lint even runs. Co-authored-by: danielxu0307 <danielxu0307@gmail.com>
Snapshot totals now sum every account (holdings where we have them, balances otherwise) so a brokerage without positions is not dropped. Stale account or position filters fall back to the full portfolio. The daily snapshot retries after a failure and again after UTC midnight. Range cutoffs clamp the day so March 31 minus one month is February 28, and changing the series clears the hover tip. Co-authored-by: danielxu0307 <danielxu0307@gmail.com>
Hidden, closed, and non-investment positions were still in the list and donut after the total started skipping them. All three now use the same active investment accounts. Co-authored-by: danielxu0307 <danielxu0307@gmail.com>
Greptile SummaryThis update adds investment-history snapshots and trend views for portfolios, accounts, and holdings. The historical fallback now excludes hidden and closed investment accounts, and Plaid synchronization removes positions that are no longer returned before calculating a new investment snapshot. Confidence Score: 5/5No blocking failure remains. The executed account-history calculation excluded hidden and closed accounts, and the holdings reconciliation calculation removed absent positions while preserving positions from other financial institutions.
What T-Rex did
Reviews (2): Last reviewed commit: "Keep investment history and holdings in ..." | Re-trigger Greptile |
ApprovabilityVerdict: Needs human review This PR introduces a new investment history/trend feature with a new database table, new API endpoints, new UI components, and integration into existing sync workflows. New features of this scope warrant human review. You can customize Macroscope's approvability policy. Learn more. |
Fallback history now ignores hidden and closed accounts, matching the snapshots we write, so the line does not drop when those begin. A Plaid holdings sync also deletes positions that left the item, so a sold security does not keep inflating the chart. Co-authored-by: danielxu0307 <danielxu0307@gmail.com>
Daily snapshots now store mark values so the chart matches the live book, and a quote refresh rewrites today's point. Drop the unused PortfolioChart now that the page uses TrendLineChart. Co-authored-by: danielxu0307 <danielxu0307@gmail.com>
Keep prior close/open when a quote omits them, show day P&L only when every quoteable holding is covered, treat the oldest quote as freshness, and prefer snapshot history over bars reconstructed from today's quantity. Co-authored-by: danielxu0307 <danielxu0307@gmail.com>
Investments was a snapshot: today's total, a donut, a list. You could not see whether the portfolio had moved, and you could not isolate one account or one position.
The tab now has the same daily line as net worth. It opens on total investments. A picker — or clicking a holding or account — focuses the line on that series, with the same range chips (1M / 3M / YTD / 1Y / ALL).
Daily investment snapshots record account and position values so the line can grow. Until those exist, older net-worth account balances fill in the total and per-account views. A single position only has history from the first day we recorded it.
The net-worth chart now uses the same
TrendLineChartso the two pages stay in step.Note
Add investment trend chart with range selection and per-account/holding filtering
SearchSelect.investmentSnapshotstable andwriteInvestmentSnapshotto record daily total, per-account, and per-holding values; snapshots are written on Plaid sync and net worth snapshots.investments.historyquery that builds a daily value series from investment and net-worth snapshots, with gap-filling and range cutoff logic inconvex/lib/investmentHistory.ts.TrendLineChartcomponent.investments.portfolionow limits returned holdings to active investment accounts and computestotalValueper-account (falling back tocurrentBalancewhen no holdings exist);upsertHoldingsdeletes stale holdings after sync.Macroscope summarized d047622.