More smashing bugs and Markdown Stances support - #14
Merged
Merged
Conversation
Contributor
Qodana Community for JVM3 new problems were found
💡 Qodana analysis was run in the pull request mode: only the changed files were checked View the detailed Qodana reportTo be able to view the detailed Qodana report, you can either:
To get - name: 'Qodana Scan'
uses: JetBrains/qodana-action@v2025.1.1
with:
upload-result: trueContact Qodana teamContact us at qodana-support@jetbrains.com
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes significant changes to the configuration and initialization of "stances" (AI assistant personas) in the project, streamlining how stance data is managed and loaded, simplifying the settings UI, and improving the chat tool's command execution handling. The most important changes are grouped below.
Stance Configuration and Loading Improvements:
/stancesresource directory, supporting both file and JAR resource loading. This replaces the previous approach of loading from a single JSON profile, allowing for easier extension and modular configuration of stances.Stancedata model by removing thescope,executionCommand, andallowedToolsfields, centralizing all stance-specific instructions and configuration into thesystemPromptand frontmatter in the markdown files.Settings UI Simplification:
scope,executionCommand,allowedTools, andcoreWorkflowfromRoninSettingsConfigurable, making the stance configuration interface cleaner and less error-prone. [1] [2] [3] [4] [5] [6] [7] [8]System Prompt Handling:
systemPromptdirectly (as defined in the markdown), removing the hardcoded, monolithic prompt template and allowing each stance to fully define its own behavior and instructions.Chat Tool Command Execution:
currentCommandFuturefield toChatToolWindowto track the currently running command, and improved cancellation handling to prevent follow-up actions if generation is cancelled. This makes command execution safer and more responsive to user actions. [1] [2] [3]Minor Cleanups: