Skip to content

More smashing bugs and Markdown Stances support - #14

Merged
xangcastle merged 4 commits into
mainfrom
xangcastle/more-smashing-bugs
Jan 31, 2026
Merged

xangcastle merged 4 commits into
mainfrom
xangcastle/more-smashing-bugs

Conversation

@xangcastle

Copy link
Copy Markdown
Owner

This pull request makes significant changes to the configuration and initialization of "stances" (AI assistant personas) in the project, streamlining how stance data is managed and loaded, simplifying the settings UI, and improving the chat tool's command execution handling. The most important changes are grouped below.

Stance Configuration and Loading Improvements:

  • Refactored stance loading to dynamically parse all markdown files in the /stances resource directory, supporting both file and JAR resource loading. This replaces the previous approach of loading from a single JSON profile, allowing for easier extension and modular configuration of stances.
  • Simplified the Stance data model by removing the scope, executionCommand, and allowedTools fields, centralizing all stance-specific instructions and configuration into the systemPrompt and frontmatter in the markdown files.

Settings UI Simplification:

  • Removed all UI fields and logic related to scope, executionCommand, allowedTools, and coreWorkflow from RoninSettingsConfigurable, making the stance configuration interface cleaner and less error-prone. [1] [2] [3] [4] [5] [6] [7] [8]

System Prompt Handling:

  • Updated the LLM service to use the stance's systemPrompt directly (as defined in the markdown), removing the hardcoded, monolithic prompt template and allowing each stance to fully define its own behavior and instructions.

Chat Tool Command Execution:

  • Added a currentCommandFuture field to ChatToolWindow to track the currently running command, and improved cancellation handling to prevent follow-up actions if generation is cancelled. This makes command execution safer and more responsive to user actions. [1] [2] [3]

Minor Cleanups:

  • Removed obsolete comments and code related to history pruning and custom endpoint handling in the LLM service.

@xangcastle xangcastle changed the title More smashing bugs More smashing bugs and Markdown Stances support Jan 31, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Qodana Community for JVM

3 new problems were found

Inspection name Severity Problems
Unused import directive 🔶 Warning 1
Unstable API Usage 🔶 Warning 1
Unused symbol 🔶 Warning 1

💡 Qodana analysis was run in the pull request mode: only the changed files were checked

View the detailed Qodana report

To be able to view the detailed Qodana report, you can either:

To get *.log files or any other Qodana artifacts, run the action with upload-result option set to true,
so that the action will upload the files as the job artifacts:

      - name: 'Qodana Scan'
        uses: JetBrains/qodana-action@v2025.1.1
        with:
          upload-result: true
Contact Qodana team

Contact us at qodana-support@jetbrains.com

@xangcastle
xangcastle merged commit e3671f8 into main Jan 31, 2026
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant