Conversation
Update vcpkgGitCommitId to match builtin-baseline in vcpkg.json (5dfa11cf) so that eigen3@3.4.1#1 and libigl@2.6.0 are available in the registry. Update actions/checkout, actions/cache, and actions/setup-dotnet from v3 to v4 to resolve Node.js 20 deprecation warnings. Agent-Logs-Url: https://github.com/xarthurx/igMesh/sessions/52dd344b-e068-4689-b815-03171269cf19 Co-authored-by: xarthurx <1921878+xarthurx@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
xarthurx
April 1, 2026 13:18
View session
There was a problem hiding this comment.
Pull request overview
Fixes the C++ CI workflow by pinning vcpkg to a commit that contains the builtin-baseline referenced by vcpkg.json, and updates first-party GitHub Actions to their v4 releases.
Changes:
- Bump
actions/checkout,actions/cache, andactions/setup-dotnetfrom v3 to v4. - Update
vcpkgGitCommitIdto align with thebuiltin-baselineused by the repo’svcpkg.json.
| uses: lukka/run-vcpkg@v11 | ||
| with: | ||
| vcpkgGitCommitId: ce613c41372b23b1f51333815feb3edd87ef8a8b # 2025-04-09 version | ||
| vcpkgGitCommitId: 5dfa11cf88a8da8877b54fcbc5f6db78bc13f75a # matches builtin-baseline in vcpkg.json |
There was a problem hiding this comment.
The new comment explains intent, but it removes the previous date-based context and doesn’t identify which vcpkg.json it refers to. To make future maintenance and audits easier, consider expanding the comment to include (a) the path to the vcpkg.json whose builtin-baseline this matches and (b) a human-friendly date (or the baseline value) alongside the commit hash.
Suggested change
| vcpkgGitCommitId: 5dfa11cf88a8da8877b54fcbc5f6db78bc13f75a # matches builtin-baseline in vcpkg.json | |
| vcpkgGitCommitId: 5dfa11cf88a8da8877b54fcbc5f6db78bc13f75a # matches builtin-baseline in GeoSharPlusCPP/vcpkg.json (builtin-baseline: 5dfa11cf88a8da8877b54fcbc5f6db78bc13f75a, as of 2024-03-01) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
build-cppfails becausevcpkg.jsonwas updated with a newerbuiltin-baselinereferencingeigen3@3.4.1#1andlibigl@2.6.0, but the workflow still checked out an older vcpkg snapshot that doesn't have those versions in its registry.vcpkg version mismatch
vcpkgGitCommitIdto5dfa11cf88a8da8877b54fcbc5f6db78bc13f75ato matchbuiltin-baselineinGeoSharPlusCPP/vcpkg.jsonDeprecated Actions (Node.js 20 → 24 migration)
actions/checkoutv3 → v4actions/cachev3 → v4actions/setup-dotnetv3 → v4Note:
lukka/run-vcpkg@v11andlukka/run-cmake@v10also run on Node.js 20 but are third-party — no newer major versions available yet. These will need updating before the June 2026 Node.js 24 enforcement deadline.