Skip to content

[service.watchedlist] 1.2.1#679

Merged
enen92 merged 2 commits intoxbmc:kryptonfrom
SchapplM:krypton
Dec 16, 2017
Merged

[service.watchedlist] 1.2.1#679
enen92 merged 2 commits intoxbmc:kryptonfrom
SchapplM:krypton

Conversation

@SchapplM
Copy link
Copy Markdown

@SchapplM SchapplM commented Nov 26, 2017

Description

Checklist:

  • My code follows the add-on rules and piracy stance of this project.
  • I have read the CONTRIBUTING document
  • Each add-on submission should be a single commit with using the following style: [script.foo.bar] v1.0.0

Fixed Dropbox API change: SchapplM/xbmc-addon-service-watchedlist#30.
This Pull Request follows PR #664 from @micahg. He pushed the update to branch krypton (presumably due to stricter dependencies for the requests-addon).
This addon was on branch isengard before, but to be able to match the dropbox dependency, I also moved it to krypton. I could also try to keep it in isengard for compatibilty (all features except dropbox would keep working).
The diff should only contain the latest changes of https://github.com/SchapplM/xbmc-addon-service-watchedlist/commits/master.

Copy link
Copy Markdown
Member

@enen92 enen92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd appreciate if the language stuff is adjusted. After that it is okay to go

Comment thread service.watchedlist/.gitignore Outdated
@@ -0,0 +1,3 @@
*.pyo

This comment was marked as spam.

Comment thread service.watchedlist/addon.xml Outdated
provider-name="schapplm">
<requires>
<import addon="xbmc.python" version="2.25.0"/>
<import addon="script.module.simplejson" version="2.0.10" />

This comment was marked as spam.

<requires>
<import addon="xbmc.python" version="2.25.0"/>
<import addon="script.module.simplejson" version="2.0.10" />
<import addon="script.module.buggalo" version="1.1.3" /> <!-- min. version 1.1.3 for email report -->

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

Comment thread service.watchedlist/addon.xml Outdated
<extension point="xbmc.service" library="default.py" start="login" /> <!-- Python code for autostart -->
<extension point="xbmc.python.module" library="lib" /> <!-- entry to access the WatchedList from other addons -->
<extension point="xbmc.addon.metadata">
<summary lang="en">Save watched Movies and TV Episodes independent from filenames</summary>

This comment was marked as spam.

Comment thread service.watchedlist/default.py Outdated
sys.exit(1)

# Run the program
xbmc.sleep(1500) # wait 1.5 seconds to prevent import-errors

This comment was marked as spam.

@@ -0,0 +1,416 @@
# XBMC Media Center language file

This comment was marked as spam.

@@ -0,0 +1,386 @@
# XBMC Media Center language file

This comment was marked as spam.

@@ -0,0 +1,410 @@
# XBMC Media Center language file

This comment was marked as spam.

@SchapplM
Copy link
Copy Markdown
Author

Thanks for your feedback. I implemented everything except the part regarding buggalo. Please see my comment after your review comment

Copy link
Copy Markdown
Member

@enen92 enen92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks much for adjusting. Regarding buggalo, I left a comment in-line with yours.
Regards

@enen92 enen92 merged commit a983be3 into xbmc:krypton Dec 16, 2017
@SchapplM SchapplM mentioned this pull request Dec 23, 2017
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants