Skip to content

Update GLM to v1.0.3#134

Merged
garbear merged 1 commit intoxbmc:Piersfrom
garbear:update-glm
Mar 10, 2026
Merged

Update GLM to v1.0.3#134
garbear merged 1 commit intoxbmc:Piersfrom
garbear:update-glm

Conversation

@garbear
Copy link
Copy Markdown
Member

@garbear garbear commented Mar 10, 2026

Description

Split out from #133

How has this been tested?

Tested along with #133 on all platforms. Windows has a black screen, but that's probably due to the 4.x port.

@kodiai
Copy link
Copy Markdown

kodiai bot commented Mar 10, 2026

Kodiai Review Summary

What Changed

Updates GLM dependency from v1.0.1 to v1.0.3, switching from GitHub archive URL to release download URL and updating the SHA256 hash.

Reviewed: core logic, docs

Strengths

  • ✅ SHA256 hash updated alongside download URL, maintaining integrity verification (glm.sha256:1)
  • ✅ Version bump is explicit and traceable through the release URL format (glm.txt:1)

Observations

Impact

[CRITICAL] depends/common/glm/glm.txt (1): Archive format change may break extraction path expectations
The URL switches from archive/1.0.1.tar.gz (extracts to glm-1.0.1/) to releases/download/1.0.3/glm-1.0.3.zip (may extract to different directory). Build system must handle the new extraction directory structure or builds will fail when searching for GLM headers.

Verdict

🔴 Address before merging -- 1 blocking issue(s) found (CRITICAL/MAJOR)

Review Details
  • Files reviewed: 2
  • Lines changed: +2 -2
  • Profile: strict (auto, lines changed: 4)
  • Author: core (adapted tone)
  • Findings: 1 critical, 0 major, 0 medium, 0 minor (includes 1 from summary observations)
  • Review completed: 2026-03-10T21:05:34.141Z
  • Keyword parsing: No keywords detected

@garbear garbear merged commit 27f0a6b into xbmc:Piers Mar 10, 2026
7 of 8 checks passed
@garbear garbear deleted the update-glm branch March 10, 2026 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant