Serialize test env var mutations to fix flaky provider tests#1
Open
xeb wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
ENV_LOCK(LazyLock<Mutex<()>>) insrc/provider.rsand acquire the lock at the start of each env-mutating provider test to serialize environment variable changes without touching production code.Testing
cargo test provider::tests::test_azure_openai_requires_env_vars,cargo test provider::tests::test_gemini_3_flash_preview_uses_native_api, and the fullcargo test, and observed the targeted tests and the full suite succeed (previously two provider tests were flaky; after the change the suite passed: all tests passed).Codex Task