[resiliency]: Fix ValueError if /etc/xensource-inventory has lines without =#146
Open
bernhardkaindl wants to merge 6 commits into
Open
Conversation
Signed-off-by: Bernhard Kaindl <bernhard.kaindl@cloud.com>
… allowed_keys Signed-off-by: Bernhard Kaindl <bernhard.kaindl@cloud.com>
Signed-off-by: Bernhard Kaindl <bernhard.kaindl@cloud.com>
…atches Signed-off-by: Bernhard Kaindl <bernhard.kaindl@cloud.com>
… condition away Signed-off-by: Bernhard Kaindl <bernhard.kaindl@cloud.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR simplifies the readKeyValueFile() function in xen-bugtool by removing unused parameters and dead code while improving resource management. The changes also update GitHub workflow configuration and codecov settings.
- Removes unused
allowed_keysandstrip_quotesparameters fromreadKeyValueFile() - Replaces manual file handling with context manager for proper resource management
- Updates SonarCloud action and codecov configuration
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| xen-bugtool | Simplifies readKeyValueFile() function by removing unused parameters and using context manager |
| .github/workflows/main.yml | Updates SonarCloud action to SonarQube scan action with error handling |
| .codecov.yml | Updates codecov configuration comments and removed_code_behavior setting |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
…thout = Signed-off-by: Bernhard Kaindl <bernhard.kaindl@cloud.com>
9fa2cb9 to
c350063
Compare
xen-bugtool/readKeyValueFile(): Remove unused code and simplify the remaining coderesiliency]: Fix ValueError if /etc/xensource-inventory has lines without =
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
xen-bugtool/readKeyValueFile(): Remove unused code and simplify the remaining codexen-bugtool/readKeyValueFile(): Usecontextmanagerforopen/close