CP-312965: Port to Python 3. Removed obsolete example.#55
Open
kc284 wants to merge 2 commits into
Open
Conversation
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
kc284
force-pushed
the
private/kc284/python3
branch
from
936649f to
5e156ad
Compare
kc284
changed the title
xueqingz
reviewed
Jun 5, 2026
xueqingz
reviewed
Jun 5, 2026
Contributor
|
Also I miss a comment, do we need to update python files under /misc ? |
Contributor
Author
|
Ah yes, I didn't think about the files under /misc. I'll look into it - but if you don't mind I'll raise a new PR to keep things separate. |
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
kc284
force-pushed
the
private/kc284/python3
branch
from
a0a691d to
fbd0ac7
Compare
xueqingz
reviewed
Jun 9, 2026
| if not tasks: | ||
| return 0 | ||
|
|
||
| if not(wait_for_tasks(session, map(lambda x:x[0], tasks), 60)): |
Contributor
There was a problem hiding this comment.
Just find this, here may need change to if not(wait_for_tasks(session, [t[0] for t in tasks], 60)): ? same for line 184. You can have a confirm.
In Python 2, map() returned a list, but in Python 3 map() returns a single-use iterator. The first pass of the while loop consumes it; on every later pass for task in tasks iterates over nothing, finished stays True, and the function returns immediately.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.