Value: add DLLStorageClass and SetDLLStorageClass

[zhouguangyuan0718]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @zhouguangyuan0718, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces the concept of DLL storage classes to the ir.go file. It defines the DLLStorageClass type and its associated constants, as well as a function to set the DLL storage class for a given value. This enhancement allows for better control and specification of DLL storage properties within the LLVM IR.

Highlights

• New DLL Storage Class: Introduced DLLStorageClass to represent the storage class of a DLL, including DefaultStorageClass, DLLImportStorageClass, and DLLExportStorageClass.
• Setter Function: Added SetDLLStorageClass function to set the DLL storage class for a given value.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request successfully introduces the DLLStorageClass type and its associated constants, along with the SetDLLStorageClass method for the Value type. The implementation appears correct and aligns with the LLVM C API bindings.

[fennoai]

The implementation is correct and follows existing patterns well. One gap: the getter DLLStorageClass() is absent despite being named in the PR title and having a direct LLVM C counterpart (LLVMGetDLLStorageClass). All other value attributes in this file (Linkage, Visibility) expose both getter and setter — this should too. See inline comment for the suggested addition.