Conversation
- store mapping as json - midi channel is 0xRRCCTT (TT for type, CC for channel, RR for target) - drop unneeded base64 encoding and decoding (might be slow) - use QHash internally, should be faster
Use more appropriate/efficient data containers
Second byte is a part of value, id cannot contain it
Encoders does not use two's complement in Mackie control protocol
- use own timer for each fader - handle OSC
This sets up faders positions when midi device is connected during app runtime.
It was unneccessary complicated
There is no need to move a fader when a button is pressed. It even could cause a position desynchronization.
Blinking on desynced fader has to be initialized on app start
setMaster pair is called from the construtor. It cannot change the number of faders unconditionally, reset to 10 has to occur only when master fader pair was used before.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test