fix: terminal PTY write/resize errors silently swallowed#747
Merged
Conversation
Replace empty `.catch(() => {})` blocks in PTY IPC calls with proper
error logging. Write and resize failures use `ptyWarn` (persisted to
log file in production) since they indicate data loss or geometry
mismatch. Kill, pause, resume, and close use `terminalLog` (dev-only
debug) since fire-and-forget semantics are acceptable there.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Owner
Author
|
✅ VERIFIED — All 7 silent |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #698
Summary
.catch(() => {})blocks in all 7 PTY IPC calls with proper error loggingpty_writeandpty_resizefailures useptyWarn(persisted to log file in production) — these indicate data loss or geometry mismatchpty_kill,pty_pause,pty_resume,pty_closefailures useterminalLog(dev-only debug) — fire-and-forget semantics are acceptableptyWarnlogger tosrc/utils/debug.tsinstanceofguardTest plan
pnpm check:allpasses (lint + coverage + build)🤖 Generated with Claude Code