fix: multi-cursor overlapping selection ranges not pre-merged before input#748
Merged
fix: multi-cursor overlapping selection ranges not pre-merged before input#748
Conversation
…ping selection ranges (Closes #693) Pre-merge overlapping ranges via normalizeRangesWithPrimary() at the start of handleMultiCursorInput, handleMultiCursorBackspace, and handleMultiCursorDelete so stale positions don't corrupt edits. Added 4 tests: overlapping ranges with input, backspace, delete, and a chain of 3 overlapping ranges. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Owner
Author
|
✅ VERIFIED — The PR adds the exact tests requested in #693 (overlapping ranges for input, backspace, and delete operations, plus a 3-range chain variant) and includes the corresponding pre-merge fix in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
normalizeRangesWithPrimary()at the start ofhandleMultiCursorInput,handleMultiCursorBackspace, andhandleMultiCursorDelete— prevents stale positions from corrupting editsTest plan
edgeCases.test.tspasspnpm check:all)Closes #693
🤖 Generated with Claude Code