fix: code fence boundary detection treats closing fences as opening fences#750
Merged
fix: code fence boundary detection treats closing fences as opening fences#750
Conversation
…ences in sourceSelectOccurrence (Closes #696) Add parity-based open/close discrimination to getCodeFenceBounds(). The backward scan now counts all fence lines above the found line — if the count is odd, the found line is a closing fence and the cursor is not inside a code block. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Owner
Author
|
✅ VERIFIED — The audit finding is resolved. The parity check correctly distinguishes closing fences from opening fences by counting prior fence lines (even = opener, odd = closer), which prevents phantom fence boundaries when the cursor is between two code blocks — exactly the root cause described in #696. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #696
Summary
getCodeFenceBounds()insourceSelectOccurrence.tsTest plan
pnpm vitest run src/plugins/codemirror/sourceSelectOccurrence.test.ts(14/14)pnpm check:allpasses (1 pre-existing flaky failure insourcePeekEditor.test.tsunrelated to this change)🤖 Generated with Claude Code