fix(ton-trading-bot): fix SQL injection in risk metrics and scheduled trades queries#72
Merged
xlabtg merged 3 commits intoxlabtg:mainfrom Mar 27, 2026
Merged
Conversation
Adding .gitkeep for PR creation (default mode). This file will be removed when the task is complete. Issue: xlabtg#64
… trades queries Replace string interpolation of `mode` and `status` enum values in SQL queries with parameterized `?` placeholders, consistent with all other queries in the file. Adds 4 regression tests that verify injection payloads never appear in query strings. Fixes xlabtg#64 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
konard
changed the title
This reverts commit 0bd6738.
Author
🤖 Solution Draft LogThis log file contains the complete execution trace of the AI solution draft process. 💰 Cost estimation:
🤖 Models used:
📎 Log file uploaded as Gist (863KB)Now working session is ended, feel free to review and add any feedback on the solution draft. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ton-trading-bot/index.jsused template-literal string interpolation to embed enum values (modeandstatus) directly into SQL strings, making them vulnerable to SQL injection.?placeholders and passed the values as bound parameters — exactly how every other query in the file already works.tests/index.test.jsthat assert (1) the SQL string never contains the literal value and always uses?, and (2) an injection payload (' OR '1'='1) never appears in the query string.Changed lines
index.js~L1585`AND mode = '${mode}'`"AND mode = ?"withmodeas bound paramindex.js~L2029`WHERE status = '${status}'`"WHERE status = ?"withstatusas bound paramTest plan
npm test)Fixes #64
🤖 Generated with Claude Code