[Instructions -5.25% vs main; paired PGO estimate] Carry unused green query values as their existing bytes - #122
Draft
xmakro wants to merge 1 commit into
Draft
Conversation
xmakro
force-pushed
the
perf-review-20260907/08-count-captured-tokens
branch
from
September 9, 2026 06:21
922c083 to
b663e22
Compare
xmakro
force-pushed
the
perf-review-20260907/09-carry-query-bytes
branch
from
September 9, 2026 06:21
f9ae497 to
41bd039
Compare
xmakro
changed the base branch from
perf-review-20260907/08-count-captured-tokens
to
main
September 9, 2026 06:21
xmakro
force-pushed
the
perf-review-20260907/09-carry-query-bytes
branch
from
September 13, 2026 04:01
41bd039 to
a88b5e8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Carry the prior query-data prefix and its source-file, allocation and hygiene tables, preserving offsets and verifying the full 128-bit key fingerprint. Already-carried green values avoid decoding and re-encoding. A distinct private cache version and an eight-generation Unix-only bound protect the format and mapping lifecycle.
Negative percentages mean less elapsed time or fewer resources. The title is an individual local instruction-count estimate: instructions:u as an equal-case geometric mean over the 249 Primary cases, the metric the upstream perf bot summarizes; small changes may be measurement noise.
The two recorded repetitions give aggregate instruction estimates of -5.247% and -5.247% for the title comparison. Mixed directions are marked in the title. This repeatability check is not a confidence interval.
Both compilers use the same source base, CI LLVM, fixed standard libraries, ThinLTO and jemalloc. Each has separate nine-workload Rust PGO training. The stock collector measures all 20 Primary benchmarks: 249 Check/Debug/Opt and full/incremental cases, two observations per compiler per case, alternating baseline/candidate order by crate. No other campaign builds run during measurement. Percentages are equal-case geometric means. LLVM retraining and BOLT are omitted.
This branch has one commit directly on main. Its exact measured source passed the full UI and incremental suites plus the additional suites recorded in the build provenance.
Fixed main commit:
da47efd27287edb02eed0b5a178a165c8f258e37. Measured source patch SHA-256:8bc66c80b75624b78b8ffbb280ba180fc5f983d7fe272e61b05c21d22ca1e871.Local raw measurements and per-case CSVs:
independent-pr122-main-v1-comparison.csvin the September 6 investigation directory. Build/test provenance:pgo/independent-pr122-source-timing-v1/provenance.json.